fix(rsa): reject zero-modulus JWK keys and throw on BigInteger divide-by-zero#649
Merged
kjur merged 1 commit intokjur:masterfrom Feb 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an RSA robustness/security issue where a malformed JWK RSA public key with
n = "AA"(decoded modulus = 0) could be accepted during import.Combined with BigInteger
mod(0)behavior, RSA public operations could silently degrade to deterministic wrong output.Root Cause
RSASetPublicaccepted non-empty modulus/exponent strings without validating parsed numeric values.bnpDivRemToreturned silently when divisor was zero, somodPowInt(e, 0)did not fail loudly.Changes
ext/rsa.jsRSASetPublicwith numeric checks after parsing:n <= 1eext/jsbn.jsbnpDivRemTonow throws"BigInteger divide by zero"when divisor is zero.test/qunit-do-crypto.htmlRSASetPublicrejects zero modulusKEYUTIL.getKeyrejects JWK RSA withn=0(n: "AA")BigInteger.modPowInt(..., BigInteger.ZERO)throwsVerification
modPowInt(e, 0)returned0Invalid RSA public keymodPowInt(e, 0)throwsBigInteger divide by zeronpm test(undernpm/) passes (6 passing)