Reorder logging levels#97
Conversation
| color: 'blue', | ||
| label: 'waiting', | ||
| logLevel: 'info' | ||
| logLevel: 'debug' |
There was a problem hiding this comment.
Are you sure about these changes ?
Looks like info, fav, sucess and other types should use info level by default
There was a problem hiding this comment.
I'm a bit confused here. Obviously you're right this should be info. It makes no sense that the warn is in debug, and I don't understand what the hell this changes are.
https://github.com/klaussinani/signale/blame/395c3457e3b166bb3e484994eeae7efcbfcefd69/src/types.js
Here I can see the changes that I recall committing: info, and success are at info level (fav is in debug though, but I recall making this change). So am I too tired to see what is going on here, or is it the github pr view which is broken ?
|
I have added PR #105 which have similar changes but also having corresponding changes in readme |
3 participants
Fixes #96