Skip to content

Reorder logging levels #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
b4nst wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Reorder logging levels #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
395c345
reorder log level
Sep 11, 2019
55e019b
set default logLevel to debug
Sep 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/signale.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,9 @@ class Signale {

get _logLevels() {
return {
info: 0,
debug: 0,
timer: 1,
debug: 2,
info: 2,
warn: 3,
error: 4
};
Expand All @@ -116,7 +116,7 @@ class Signale {
}

_validateLogLevel(level) {
return Object.keys(this._logLevels).includes(level) ? level : 'info';
return Object.keys(this._logLevels).includes(level) ? level : 'debug';
}

_mergeTypes(standard, custom) {
Expand Down
22 changes: 11 additions & 11 deletions src/types.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ module.exports = {
badge: figures('❤'),
color: 'magenta',
label: 'favorite',
logLevel: 'info'
logLevel: 'debug'
},
info: {
badge: figures.info,
Expand All @@ -30,7 +30,7 @@ module.exports = {
badge: figures.star,
color: 'yellow',
label: 'star',
logLevel: 'info'
logLevel: 'debug'
},
success: {
badge: figures.tick,
Expand All @@ -42,7 +42,7 @@ module.exports = {
badge: figures.ellipsis,
color: 'blue',
label: 'waiting',
logLevel: 'info'
logLevel: 'debug'
Copy link
Copy Markdown

@anru anru Dec 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about these changes ?
Looks like info, fav, sucess and other types should use info level by default

Copy link
Copy Markdown
Author

@b4nst b4nst Dec 13, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused here. Obviously you're right this should be info. It makes no sense that the warn is in debug, and I don't understand what the hell this changes are.

https://github.com/klaussinani/signale/blame/395c3457e3b166bb3e484994eeae7efcbfcefd69/src/types.js

Here I can see the changes that I recall committing: info, and success are at info level (fav is in debug though, but I recall making this change). So am I too tired to see what is going on here, or is it the github pr view which is broken ?

},
warn: {
badge: figures.warning,
Expand All @@ -54,31 +54,31 @@ module.exports = {
badge: figures.checkboxOn,
color: 'cyan',
label: 'complete',
logLevel: 'info'
logLevel: 'debug'
},
pending: {
badge: figures.checkboxOff,
color: 'magenta',
label: 'pending',
logLevel: 'info'
logLevel: 'debug'
},
note: {
badge: figures.bullet,
color: 'blue',
label: 'note',
logLevel: 'info'
logLevel: 'debug'
},
start: {
badge: figures.play,
color: 'green',
label: 'start',
logLevel: 'info'
logLevel: 'debug'
},
pause: {
badge: figures.squareSmallFilled,
color: 'yellow',
label: 'pause',
logLevel: 'info'
logLevel: 'debug'
},
debug: {
badge: figures('⬤'),
Expand All @@ -90,18 +90,18 @@ module.exports = {
badge: figures.ellipsis,
color: 'blue',
label: 'awaiting',
logLevel: 'info'
logLevel: 'debug'
},
watch: {
badge: figures.ellipsis,
color: 'yellow',
label: 'watching',
logLevel: 'info'
logLevel: 'debug'
},
log: {
badge: '',
color: '',
label: '',
logLevel: 'info'
logLevel: 'debug'
}
};