Skip to content

Conversation

@cardil
Copy link
Contributor

@cardil cardil commented Mar 14, 2025

Changes

  • 🗑️ Rm vendor

/kind cleanup

Part of knative/infra#134

@knative-prow
Copy link

knative-prow bot commented Mar 14, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 14, 2025
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 14, 2025
@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 14, 2025
@knative-prow knative-prow bot requested review from pierDipi and upodroid March 14, 2025 18:03
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 14, 2025
@codecov
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.33%. Comparing base (7431471) to head (282a3e8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #943   +/-   ##
=====================================
  Coverage   4.33%   4.33%           
=====================================
  Files         15      15           
  Lines        300     300           
=====================================
  Hits          13      13           
  Misses       287     287           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cardil cardil force-pushed the rm/vendor branch 3 times, most recently from b3a5ffd to ca18f52 Compare March 17, 2025 17:12
@cardil cardil marked this pull request as ready for review March 17, 2025 17:21
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 17, 2025
@knative-prow knative-prow bot requested a review from aliok March 17, 2025 17:21
@cardil cardil marked this pull request as draft March 17, 2025 17:21
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 17, 2025
@cardil
Copy link
Contributor Author

cardil commented Mar 17, 2025

/test all

@cardil cardil marked this pull request as ready for review March 17, 2025 17:29
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 17, 2025
@knative-prow knative-prow bot requested a review from dprotaso March 17, 2025 17:30
@cardil
Copy link
Contributor Author

cardil commented Mar 17, 2025

/assign @dprotaso

@cardil cardil marked this pull request as draft March 18, 2025 10:45
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 18, 2025
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 18, 2025
cardil added 2 commits March 19, 2025 11:56
Without vendor, the extra flags are not needed anymore
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 19, 2025
@cardil cardil marked this pull request as ready for review March 19, 2025 10:58
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2025
@knative-prow knative-prow bot requested a review from dsimansk March 19, 2025 10:58
Copy link

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2025
@dsimansk
Copy link

/lgtm

@dprotaso
Copy link
Contributor

/lgtm
/approve

@knative-prow
Copy link

knative-prow bot commented Apr 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dprotaso, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2025
@knative-prow knative-prow bot merged commit 3b5230c into knative-extensions:main Apr 11, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants