fix unused linter errors

[simkam]

Can be seen for example in: https://github.com/knative/eventing/actions/runs/21171606060/job/60889521311

  Error: pkg/requestreply/ingress_handler.go:352:6: func isResponseEvent is unused (unused)
  func isResponseEvent(event *cloudevents.Event, rr *v1alpha1.RequestReply) bool {
       ^
  Error: test/conformance/helpers/tracing_test_helper.go:53:3: const recordEventsPodName is unused (unused)
  		recordEventsPodName = "recordevents"
  		^
  Error: test/conformance/helpers/tracing_test_helper.go:98:6: func getTraceIDHeader is unused (unused)
  func getTraceIDHeader(t *testing.T, evInfos []recordevents.EventInfo) string {
       ^
  3 issues:
  * unused: 3

/kind cleanup

[knative-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: simkam
Once this PR has been reviewed and has the lgtm label, please assign cali0707 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.15%. Comparing base (71a6c9f) to head (35537d8).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8851      +/-   ##
==========================================
+ Coverage   51.13%   51.15%   +0.01%     
==========================================
  Files         409      409              
  Lines       21369    21366       -3     
==========================================
+ Hits        10928    10930       +2     
+ Misses       9588     9584       -4     
+ Partials      853      852       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[simkam]

/retest-required

[twoGiants]

I suggest to not commit commented code with a TODO because it won't be picked up. It's better to remove this entire section and replace it with a comment with a reference to an upstream help-wanted ticket which describes why this was commented and what to do about it.

[simkam]

The thing is that the code with TODO is already commented (https://github.com/knative/eventing/blob/main/test/conformance/helpers/tracing_test_helper.go#L59) but there are one const definition and one function definition that are used by only that commented code and due to that the unused linting error is triggered. I only commented pieces that are used by that already commented code.

I would rather not remove code that is supposed to be used somewhere. I don't haven't any context why that piece of code was commented.

[twoGiants]

The thing is that the code with TODO is already commented...

Yep, I am aware of that. My intention was to motivate a small clean up of what was there and needs a cleanup because you touch the code in that area anyway. And the reason for the proposed cleanup is what you said a few sentences later =>

I would rather not remove code that is supposed to be used somewhere. I don't haven't any context why that piece of code was commented.

You describe the problem right here perfectly 😆 . That is the reason to not comment and commit code, because nobody will remember why this was done and will be afraid to remove it. For that reason a ticket with a reference should be the way to go. If you don't want to remove it, it's ok but maybe create a ticket and reference it there and the ticket should be "investigate if the commented code is needed or can safely be removed" so it has the chance of being picked up.

[simkam]

ok, I agree. I logged #8853 and removed the commented code altogether.