fix: linter reporting xml unsupported type #2950
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
knative-prow
bot
added
the
size/XS
gauron99
requested review from
lkingland and
matejvasek
and removed request for
jrangelramos and
nainaz
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2950 +/- ##
==========================================
+ Coverage 58.27% 60.02% +1.74%
==========================================
Files 132 132
Lines 16835 16836 +1
==========================================
+ Hits 9811 10106 +295
+ Misses 6123 5772 -351
- Partials 901 958 +57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/retest |
| Namespace string `json:"namespace" yaml:"namespace"` | ||
| Subscriptions []Subscription `json:"subscriptions" yaml:"subscriptions"` | ||
| Labels map[string]string `json:"labels" yaml:"labels"` | ||
| Labels map[string]string `json:"labels" yaml:"labels" xml:"-"` |
There was a problem hiding this comment.
Why only Labels require this?
There was a problem hiding this comment.
trying to marshal unsupported type map[string]string, via x.Labels (staticcheck)
because of the map type, im assuming by the linter message
|
/lgtm |
2 participants
linter failing in main https://github.com/knative/func/actions/runs/16489108500/job/46619720738#step:4:12