Skip to content

fix: linter reporting xml unsupported type #2950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow merged 1 commit into from
Jul 27, 2025
Merged

fix: linter reporting xml unsupported type #2950

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/functions/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ type Instance struct {
Image string `json:"image" yaml:"image"`
Namespace string `json:"namespace" yaml:"namespace"`
Subscriptions []Subscription `json:"subscriptions" yaml:"subscriptions"`
Labels map[string]string `json:"labels" yaml:"labels"`
Labels map[string]string `json:"labels" yaml:"labels" xml:"-"`
Copy link
Contributor

@matejvasek matejvasek Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why only Labels require this?

Copy link
Contributor Author

@gauron99 gauron99 Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trying to marshal unsupported type map[string]string, via x.Labels (staticcheck)

because of the map type, im assuming by the linter message

}

// Subscriptions currently active to event sources
Expand Down
Loading