AP-25527: Use ai-settings for persisting K-AI disclaimer dismissal by iusethemouse · Pull Request #112 · knime/knime-ui

iusethemouse · 2026-02-09T20:00:50Z

Currently, when you click "Accept and continue" under K-AI's disclaimer in K-AI's sidepanel or in Quick Build mode with "Do not ask again" checked, the choice was persisted to localStorage. This has always been problematic and brittle, often breaking, and currently not working in AP-in-browser.

We recently introduced "AI settings" to knime-ui, which are persisted the same way as "UI settings" (i.e. knime-ui-settings.yaml) - either in .knime/profile on Desktop AP, or in localStorage in browser. It makes sense to utilise this new persistence mechanism for K-AI's disclaimer as well.

Core requirements for the disclaimer:

✅ Should be shown once in K-AI sidepanel/Quick Build panel after user logs into Hub.
✅ Should be shown again after AP restart.
✅ Should not be shown to the user after AP restart if "Do not ask again" was checked upon dismissal.
✅ Should be shown again if persistently dismissed but the disclaimer text has changed (the text comes from the AI service in Hub).
✅ Should be shown again if user sets a different Hub as K-AI's backend Hub

With these changes, I am expecting persistent K-AI disclaimer dismissal to finally work properly both in Dekstop AP and in browser.

Example of what .knime/profile/ai-settings.yaml looks like after dismissing the disclaimer with "Do not ask again":

"3949c956":
  disclaimer:
    disclaimerTextHash: "02e08486"
    lastUpdated: "2026-02-12T13:03:20.999Z"

, where "3949c956" is the hash of username and Hub ID.

Quick visual as a refresher of what "K-AI disclaimer" is:

iusethemouse · 2026-02-09T20:48:13Z

A small quality-of-life bit of work here, danke @hriverahdez 🙏

org.knime.ui.js/src/components/kai/panels/useDisclaimer.ts

org.knime.ui.js/src/store/ai/aiSettings.ts

hriverahdez

@iusethemouse just marking this as request for changes in the meantime, to avoid an accidental merge.
ping me if/when you want me to re-review it

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

org.knime.ui.js/src/store/ai/aiSettings.ts

org.knime.ui.js/src/util/projectUtil.ts

iusethemouse · 2026-02-12T13:42:58Z

@iusethemouse just marking this as request for changes in the meantime, to avoid an accidental merge. ping me if/when you want me to re-review it

Ready for another look @hriverahdez

org.knime.ui.js/src/store/ai/__tests__/aiSettings.test.ts

org.knime.ui.js/src/store/ai/aiSettings.ts

org.knime.ui.js/src/util/projectUtil.ts

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-13T13:20:08Z

org.knime.ui.js/src/components/kai/panels/useDisclaimer.ts

+  const closeDisclaimer = async (persistently: boolean = true) => {
+    hasBeenDismissed.value = true;

-    if (localStorageKey.value && persistently) {
-      localStorage.setItem(localStorageKey.value, "true");
+    if (persistently && disclaimerText.value) {
+      await aiSettingsStore.dismissDisclaimer(disclaimerText.value);
    }
  };


The closeDisclaimer function is async but may be called without awaiting by the consumer. While this won't cause an error, it means the UI could proceed before the dismissal is persisted to settings. If the user closes the app or tab immediately after calling this function, the dismissal might not be saved. Consider documenting this behavior or having callers await the promise to ensure persistence completes before allowing the user to proceed.

jesus christ, this guy always has something to say...

iusethemouse · 2026-02-13T14:01:16Z

Sorry for the continuous pings, ready again @hriverahdez

Thanks for all the tips, things are in a much better place thanks to them

…issal

…nd nothing else

…root properties

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

sonarqubecloud · 2026-02-13T15:38:53Z

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
89.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copilot AI review requested due to automatic review settings February 9, 2026 20:00

iusethemouse changed the title ~~AP-25527: Use ai-settings (.knime/profile/localStorage) for persisting K-AI disclaimer dismissal~~ AP-25527: Use ai-settings for persisting K-AI disclaimer dismissal Feb 9, 2026

This comment was marked as resolved.

Sign in to view

iusethemouse force-pushed the enh/AP-25527-use-ai-settings-for-kai-disclaimer branch from 158da5e to 9217096 Compare February 9, 2026 20:17

Copilot AI review requested due to automatic review settings February 9, 2026 20:30

iusethemouse force-pushed the enh/AP-25527-use-ai-settings-for-kai-disclaimer branch from 9217096 to c2ef54c Compare February 9, 2026 20:30

This comment was marked as resolved.

Sign in to view

iusethemouse marked this pull request as ready for review February 9, 2026 20:46

iusethemouse requested a review from a team as a code owner February 9, 2026 20:46

iusethemouse requested review from hriverahdez and knime-ghub-bot and removed request for a team February 9, 2026 20:46

hriverahdez reviewed Feb 11, 2026

View reviewed changes

org.knime.ui.js/src/components/kai/panels/useDisclaimer.ts Outdated Show resolved Hide resolved

org.knime.ui.js/src/store/ai/aiSettings.ts Outdated Show resolved Hide resolved

iusethemouse force-pushed the enh/AP-25527-use-ai-settings-for-kai-disclaimer branch from c2ef54c to ac219b6 Compare February 11, 2026 13:24

iusethemouse requested a review from hriverahdez February 11, 2026 13:33

hriverahdez requested changes Feb 12, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings February 12, 2026 13:22

iusethemouse force-pushed the enh/AP-25527-use-ai-settings-for-kai-disclaimer branch from ac219b6 to 97f4bf2 Compare February 12, 2026 13:22

Copilot AI reviewed Feb 12, 2026

View reviewed changes

org.knime.ui.js/src/store/ai/aiSettings.ts Show resolved Hide resolved

org.knime.ui.js/src/store/ai/aiSettings.ts Show resolved Hide resolved

org.knime.ui.js/src/store/ai/aiSettings.ts Show resolved Hide resolved

org.knime.ui.js/src/store/ai/aiSettings.ts Show resolved Hide resolved

iusethemouse commented Feb 12, 2026

View reviewed changes

org.knime.ui.js/src/store/ai/aiSettings.ts Outdated Show resolved Hide resolved

iusethemouse commented Feb 12, 2026

View reviewed changes

org.knime.ui.js/src/store/ai/aiSettings.ts Outdated Show resolved Hide resolved

iusethemouse commented Feb 12, 2026

View reviewed changes

org.knime.ui.js/src/util/projectUtil.ts Show resolved Hide resolved

iusethemouse requested review from Copilot and hriverahdez February 12, 2026 13:42

This comment was marked as resolved.

Sign in to view

hriverahdez reviewed Feb 13, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings February 13, 2026 13:15

iusethemouse force-pushed the enh/AP-25527-use-ai-settings-for-kai-disclaimer branch from a141e48 to 98ceb3f Compare February 13, 2026 13:15

Copilot started reviewing on behalf of iusethemouse February 13, 2026 13:16 View session

Copilot AI reviewed Feb 13, 2026

View reviewed changes

hriverahdez approved these changes Feb 13, 2026

View reviewed changes

iusethemouse added 10 commits February 13, 2026 16:25

AP-25527: Use the new ai-settings for persisting K-AI disclaimer dism…

14201ee

…issal

AP-25527: Improve code readability

0ed3205

AP-25527: Simplify toStableProjectId by only using project origin a…

19705de

…nd nothing else

AP-25527: Re-organise ai-settings data structure to have user-hub as …

67b4bf9

…root properties

AP-25527: Allow resetting disclaimer dismissal status

fe7fbea

AP-25527: Finish comment

6d41dcf

AP-25527: Remove invalid boolean return statement

a76262e

AP-25527: Improve code readability and structure

1727db9

AP-25527: Improve pruning and cleaning logic

3be2435

AP-25527: Use factory functions in test suite

6163e97

Copilot AI review requested due to automatic review settings February 13, 2026 15:25

iusethemouse force-pushed the enh/AP-25527-use-ai-settings-for-kai-disclaimer branch from af2143e to 6163e97 Compare February 13, 2026 15:25

Copilot started reviewing on behalf of iusethemouse February 13, 2026 15:25 View session

Copilot AI reviewed Feb 13, 2026

View reviewed changes

iusethemouse merged commit a04728b into master Feb 13, 2026
12 checks passed

iusethemouse deleted the enh/AP-25527-use-ai-settings-for-kai-disclaimer branch February 13, 2026 15:40

Conversation

iusethemouse commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

iusethemouse commented Feb 9, 2026

Uh oh!

Uh oh!

Uh oh!

hriverahdez left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iusethemouse commented Feb 12, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

iusethemouse Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

iusethemouse commented Feb 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

sonarqubecloud bot commented Feb 13, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

iusethemouse commented Feb 9, 2026 •

edited

Loading