Skip to content

AP-25527: Use ai-settings for persisting K-AI disclaimer dismissal #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iusethemouse merged 10 commits into from
Feb 13, 2026
Merged

AP-25527: Use ai-settings for persisting K-AI disclaimer dismissal #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
14201ee
AP-25527: Use the new ai-settings for persisting K-AI disclaimer dism…
iusethemouse Feb 9, 2026
0ed3205
AP-25527: Improve code readability
iusethemouse Feb 11, 2026
19705de
AP-25527: Simplify `toStableProjectId` by only using project origin a…
iusethemouse Feb 12, 2026
67b4bf9
AP-25527: Re-organise ai-settings data structure to have user-hub as …
iusethemouse Feb 12, 2026
fe7fbea
AP-25527: Allow resetting disclaimer dismissal status
iusethemouse Feb 12, 2026
6d41dcf
AP-25527: Finish comment
iusethemouse Feb 12, 2026
a76262e
AP-25527: Remove invalid boolean return statement
iusethemouse Feb 12, 2026
1727db9
AP-25527: Improve code readability and structure
iusethemouse Feb 13, 2026
3be2435
AP-25527: Improve pruning and cleaning logic
iusethemouse Feb 13, 2026
6163e97
AP-25527: Use factory functions in test suite
iusethemouse Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 11 additions & 23 deletions org.knime.ui.js/src/components/kai/panels/useDisclaimer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,41 +1,29 @@
import { computed, ref } from "vue";

import { encodeString } from "@/util/encodeString";
import { useHubAuth } from "../useHubAuth";
import { useAISettingsStore } from "@/store/ai/aiSettings";
import { useKaiServer } from "../useKaiServer";

const _shouldShowDisclaimer = ref(true);
const hasBeenDismissed = ref(false);

export const useDisclaimer = () => {
const { uiStrings } = useKaiServer();
const disclaimerText = computed(() => uiStrings.disclaimer ?? "");

const { hubID, username } = useHubAuth();
const aiSettingsStore = useAISettingsStore();

const localStorageKey = computed(() => {
if (!hubID.value || !username.value || !disclaimerText.value) {
return null;
}
const identifier = `${hubID.value}${username.value}${disclaimerText.value}`;
return `kai-persistently-hide-disclaimer-${encodeString(identifier)}`;
});

const persistentlyHideDisclaimer = computed(() =>
localStorageKey.value
? Boolean(localStorage.getItem(localStorageKey.value))
: false,
);

const closeDisclaimer = (persistently: boolean = true) => {
_shouldShowDisclaimer.value = false;
const closeDisclaimer = async (persistently: boolean = true) => {
hasBeenDismissed.value = true;

if (localStorageKey.value && persistently) {
localStorage.setItem(localStorageKey.value, "true");
if (persistently && disclaimerText.value) {
await aiSettingsStore.dismissDisclaimer(disclaimerText.value);
}
};
Comment on lines +14 to 20
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The closeDisclaimer function is async but may be called without awaiting by the consumer. While this won't cause an error, it means the UI could proceed before the dismissal is persisted to settings. If the user closes the app or tab immediately after calling this function, the dismissal might not be saved. Consider documenting this behavior or having callers await the promise to ensure persistence completes before allowing the user to proceed.

Copilot uses AI. Check for mistakes.
Copy link
Member Author

@iusethemouse iusethemouse Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jesus christ, this guy always has something to say...


const shouldShowDisclaimer = computed(
() => _shouldShowDisclaimer.value && !persistentlyHideDisclaimer.value,
() =>
!hasBeenDismissed.value &&
Boolean(disclaimerText.value) &&
!aiSettingsStore.isDisclaimerDismissed(disclaimerText.value),
);

return { disclaimerText, closeDisclaimer, shouldShowDisclaimer };
Expand Down
Loading
Loading