fix: move gesture handler to peer deps#928
Closed
JoaoPauloCMarra wants to merge 1 commit intoknocklabs:mainfrom
Closed
fix: move gesture handler to peer deps#928JoaoPauloCMarra wants to merge 1 commit intoknocklabs:mainfrom
JoaoPauloCMarra wants to merge 1 commit intoknocklabs:mainfrom
Conversation
|
@JoaoPauloCMarra is attempting to deploy a commit to the Knock Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 3e91d55 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoaoPauloCMarra
requested review from
connorlindsey and
meryldakin
and removed request for
a team
kylemcd
requested review from
kylemcd
and removed request for
connorlindsey and
meryldakin
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move
react-native-gesture-handlerfrom direct dependencies to peer dependencies in the Expo and React Native packages so consumer apps own a single native install.Changes
react-native-gesture-handlertopeerDependenciesin@knocklabs/expoand@knocklabs/react-nativedevDependenciesfor local package developmentWhy
Expo Doctor flags duplicate native modules when these packages vendor their own copy of
react-native-gesture-handler.Test
node .yarn/releases/yarn-4.1.0.cjs install --mode=skip-buildnode .yarn/releases/yarn-4.1.0.cjs postinstallnode .yarn/releases/yarn-4.1.0.cjs lint --filter=@knocklabs/expo --filter=@knocklabs/react-nativenode .yarn/releases/yarn-4.1.0.cjs type:check --filter=@knocklabs/expo --filter=@knocklabs/react-native(fails in@knocklabs/react-corewith existing@knocklabs/clientresolution errors unrelated to this diff)