Skip to content

Conversation

@koji
Copy link
Owner

@koji koji commented Jun 1, 2025

… done so far and provide feedback for Jules to continue.

… done so far and provide feedback for Jules to continue.
@koji koji requested a review from Copilot June 1, 2025 04:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bootstraps a Vite-based build setup, refactors the NesTag component to use CSS Modules, and updates project dependencies and Storybook configuration to the latest Vite-compatible versions.

  • Added vite.config.ts to generate dynamic library entry points, handle CSS injection, SVGs, type declarations, and static assets.
  • Refactored src/Tag to replace styled-components with a CSS Module and updated the component to use it.
  • Overhauled package.json scripts/dependencies for Vite and Storybook v8, and replaced legacy Storybook webpack config with main.js/preview.js.

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
vite.config.ts New Vite build config with dynamic entries, plugins, and asset rules
src/Tag/index.tsx Refactored NesTag to import and use Tag.module.css
src/Tag/Tag.module.css New CSS Module containing Tag styles
package.json Swapped CRA/Rollup scripts for Vite, updated deps/devDeps
.storybook/main.js Storybook v8 config for React with Vite and updated addons
.storybook/preview.js Global CSS import and Storybook parameters setup
.storybook/webpack.config.js Removed legacy Storybook webpack config
.storybook/config.js Removed legacy Storybook config
.storybook/addons.js Removed legacy Storybook addons registrations
Comments suppressed due to low confidence (3)

src/Tag/index.tsx:2

  • [nitpick] Importing global styles at the component level can lead to duplication. Consider moving this import to a single entry point (e.g., in your app or preview setup) and documenting that consumers must include 'nes.css'.
import '../assets/nes.css';

.storybook/main.js:7

  • You’ve listed '@storybook/addon-console' in the addons array but it isn’t added to devDependencies. Either install the package or remove it from the config.
'@storybook/addon-console',

.storybook/main.js:8

  • The '@storybook/addon-storysource' addon is referenced here but not declared in devDependencies. Please add it or remove the entry.
'@storybook/addon-storysource',

koji and others added 2 commits June 1, 2025 00:21
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
@koji koji requested a review from Copilot June 2, 2025 18:54
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the project build and Storybook configuration to Vite while cleaning up obsolete webpack and Rollup settings. It also converts the Tag component from styled-components to a CSS module approach and updates package.json scripts and dependencies accordingly.

  • Introduces a new Vite configuration with dynamic entry points and asset handling.
  • Converts the Tag component styling from styled-components to CSS modules.
  • Removes legacy Storybook webpack configurations and outdated dependencies in package.json.

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
vite.config.ts Added Vite config with dynamic entry point generation and asset handling.
src/Tag/index.tsx Replaced styled-components with CSS modules and updated class name handling.
src/Tag/Tag.module.css Added CSS module definitions replicating the original styled-components styles.
package.json Updated scripts, dependencies, and removed legacy packages and tools.
.storybook/* files Removed obsolete Storybook webpack and addon configurations in favor of Vite.
Comments suppressed due to low confidence (2)

src/Tag/index.tsx:15

  • [nitpick] Consider renaming the CSS module class from 'toolTag' to 'nesTag' to more closely match the exported component name for improved consistency.
const combinedClassName = `${styles.toolTag} ${textClass}`;

package.json:65

  • The glob dependency version was downgraded from ^7.1.6 to ^7.0.0; please verify that this version is compatible with the current usage in your build scripts.
"glob": "^7.0.0",

@koji koji closed this Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant