-
Notifications
You must be signed in to change notification settings - Fork 0
Jules was unable to complete the task in time. Please review the work… #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| module.exports = { | ||
| stories: ['../src/**/*.stories.mdx', '../src/**/*.stories.@(js|jsx|ts|tsx)'], | ||
| addons: [ | ||
| '@storybook/addon-links', | ||
| '@storybook/addon-essentials', // Includes actions, backgrounds, controls, docs, viewport, toolbars | ||
| '@storybook/addon-interactions', // For play functions | ||
| '@storybook/addon-console', | ||
| '@storybook/addon-storysource', | ||
| // 'storybook-addon-jsx', // Commenting out for now, will check compatibility later if needed | ||
| ], | ||
| framework: { | ||
| name: '@storybook/react-vite', | ||
| options: {}, | ||
| }, | ||
| docs: { | ||
| autodocs: 'tag', // Enable autodocs for tagged components | ||
| }, | ||
| staticDirs: ['../public'], // Replicates -s public, assuming nes.css is imported or handled by vite-plugin-static-copy | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| // Import global CSS. This path should be accessible during Storybook build/dev. | ||
| // Since vite.config.ts copies src/assets/nes.css to lib/assets/nes.css, | ||
| // and Storybook runs from the project root, this import should resolve correctly | ||
| // IF components are expected to import it this way OR if it's for Storybook's own UI. | ||
| // However, for components in the library, they might rely on CSS modules or | ||
| // the lib consumer to include nes.css. | ||
| // For Storybook's own preview area, importing it here makes sense. | ||
| import '../src/assets/nes.css'; | ||
|
|
||
| // Attempt to migrate setConsoleOptions | ||
| // The addon-console might pick up parameters automatically or via a dedicated parameter. | ||
| // Checking addon-console documentation, it seems it might not need explicit setup here anymore for panelExclude. | ||
| // If console filtering is needed, it can be set using `parameters.console`. | ||
| // For now, we'll omit explicit setConsoleOptions as it was from Storybook v5 structure. | ||
|
|
||
| export const parameters = { | ||
| // actions: { argTypesRegex: "^on[A-Z].*" }, // Default in addon-essentials | ||
| controls: { | ||
| matchers: { | ||
| color: /(background|color)$/i, | ||
| date: /Date$/, | ||
| }, | ||
| }, | ||
| // Example for console addon parameter if needed: | ||
| // console: { | ||
| // panelExclude: [], | ||
| // }, | ||
| docs: { | ||
| // Ensures that the docs addon is configured (though autodocs in main.js is the primary switch) | ||
| } | ||
| }; | ||
|
|
||
| // Global decorators can be added here if needed. | ||
| // The `withPropsTable` from storybook-addon-react-docgen is not used with Vite. | ||
| // Component documentation (props tables) should be generated by addon-docs with react-vite. | ||
| export const decorators = [ | ||
| // Add any global decorators from the old config if they are still relevant | ||
| // e.g., if there was a global wrapper component | ||
| ]; |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| .toolTag { | ||
| background: #eee; | ||
| border-radius: 3px 0 0 3px; | ||
| color: #999; | ||
| display: inline-block; | ||
| height: 26px; | ||
| line-height: 26px; | ||
| padding: 0 20px 0 23px; | ||
| position: relative; | ||
| margin: 0 10px 10px 0; | ||
| text-decoration: none; | ||
| -webkit-transition: color 0.2s; | ||
| } | ||
|
|
||
| .toolTag::before { | ||
| background: #fff; | ||
| border-radius: 10px; | ||
| box-shadow: inset 0 1px rgba(0, 0, 0, 0.25); | ||
| content: ''; | ||
| height: 6px; | ||
| left: 10px; | ||
| position: absolute; | ||
| width: 6px; | ||
| top: 10px; | ||
| } | ||
|
|
||
| .toolTag::after { | ||
| background: #fff; | ||
| border-bottom: 13px solid transparent; | ||
| border-left: 10px solid #eee; | ||
| border-top: 13px solid transparent; | ||
| content: ''; | ||
| position: absolute; | ||
| right: 0; | ||
| top: 0; | ||
| } | ||
|
|
||
| .toolTag:hover { | ||
| background-color: #000000; | ||
| color: white; | ||
| } | ||
|
|
||
| .toolTag:hover::after { | ||
| border-left-color: #000000; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,58 +1,18 @@ | ||
| import * as React from 'react'; | ||
| import '../assets/nes.css'; | ||
| import styled from 'styled-components'; | ||
| import styles from './Tag.module.css'; | ||
|
|
||
| type Props = { | ||
| textType: 'primary' | 'success' | 'warning' | 'error'; | ||
| item: string; | ||
| }; | ||
|
|
||
| const ToolTag = styled.span` | ||
| background: #eee; | ||
| border-radius: 3px 0 0 3px; | ||
| color: #999; | ||
| display: inline-block; | ||
| height: 26px; | ||
| line-height: 26px; | ||
| padding: 0 20px 0 23px; | ||
| position: relative; | ||
| margin: 0 10px 10px 0; | ||
| text-decoration: none; | ||
| -webkit-transition: color 0.2s; | ||
| ::before { | ||
| background: #fff; | ||
| border-radius: 10px; | ||
| box-shadow: inset 0 1px rgba(0, 0, 0, 0.25); | ||
| content: ''; | ||
| height: 6px; | ||
| left: 10px; | ||
| position: absolute; | ||
| width: 6px; | ||
| top: 10px; | ||
| } | ||
| ::after { | ||
| background: #fff; | ||
| border-bottom: 13px solid transparent; | ||
| border-left: 10px solid #eee; | ||
| border-top: 13px solid transparent; | ||
| content: ''; | ||
| position: absolute; | ||
| right: 0; | ||
| top: 0; | ||
| } | ||
| :hover { | ||
| background-color: #000000; | ||
| color: white; | ||
| } | ||
| :hover::after { | ||
| border-left-color: #000000; | ||
| } | ||
| `; | ||
|
|
||
| export class NesTag extends React.Component<Props> { | ||
| render() { | ||
| const { textType, item } = this.props; | ||
| const textClass = `nes-text is-${textType}`; | ||
| return <ToolTag className={textClass}>{item}</ToolTag>; | ||
| // Combine the CSS module class for the tag's structure and the nes.css classes for text styling | ||
| const combinedClassName = `${styles.toolTag} ${textClass}`; | ||
| return <span className={combinedClassName}>{item}</span>; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.