[ISV-5784] Rewrite product-level SBOM generation#415
Merged
mmalina merged 5 commits intokonflux-ci:mainfrom Apr 24, 2025
Merged
[ISV-5784] Rewrite product-level SBOM generation#415mmalina merged 5 commits intokonflux-ci:mainfrom
mmalina merged 5 commits intokonflux-ci:mainfrom
Conversation
jedinym
force-pushed
the
refactor-product-sbom
branch
4 times, most recently
from
8a1b691 to
7a1fc04
Compare
mmalina
reviewed
Apr 22, 2025
mmalina
reviewed
Apr 22, 2025
mmalina
reviewed
Apr 22, 2025
Contributor
mmalina
left a comment
mmalina
left a comment
There was a problem hiding this comment.
I added a few comments, but I didn't go deep into the functionality. Hopefully someone else from your team can review this as well.
Contributor
Author
|
@Allda please take look 🦑 |
Contributor
|
/lgtm |
Contributor
|
Nice refactoring and usage of the spdx schema library 👍 |
johnbieren
reviewed
Apr 23, 2025
Signed-off-by: Martin Jediny <jedinym@proton.me>
The product-level SBOM generation is refactored to utilize the new sbomlib library to parse the snapshot spec. The spdx tools python library is also used to generate the SPDX SBOM. Signed-off-by: Martin Jediny <jedinym@proton.me>
Signed-off-by: Martin Jediny <jedinym@proton.me>
Signed-off-by: Martin Jediny <jedinym@proton.me>
Signed-off-by: Martin Jediny <jedinym@proton.me>
jedinym
force-pushed
the
refactor-product-sbom
branch
from
dc208f4 to
c6ab369
Compare
Contributor
Author
|
/retest |
mmalina
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The product-level SBOM generation is refactored to use the mapped snapshot spec and the merged data file as a source of truth. This makes the implementation simpler to understand and maintain.
The spdx-tools library is used to generate the SBOM and validate it, to assure its quality.
Tests are written to check that the expected properties on the SBOM hold.
This PR depends on the changes in #399.