added base files for debugger #1
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
|
|
||
| #ifndef XEUS_CPP_DEBUGGER_HPP | ||
| #define XEUS_CPP_DEBUGGER_HPP |
There was a problem hiding this comment.
warning: header guard does not follow preferred style [llvm-header-guard]
| #define XEUS_CPP_DEBUGGER_HPP | |
| #ifndef XEUS_CPP_XDEBUGGER_HPP | |
| #define XEUS_CPP_XDEBUGGER_HPP |
| #define XEUS_CPP_DEBUGGER_HPP | ||
|
|
||
| #include <map> | ||
| #include <mutex> |
There was a problem hiding this comment.
warning: included header map is not used directly [misc-include-cleaner]
| #include <mutex> | |
| #include <mutex> |
|
|
||
| #include <map> | ||
| #include <mutex> | ||
| #include <set> |
There was a problem hiding this comment.
warning: included header mutex is not used directly [misc-include-cleaner]
| #include <set> | |
| #include <set> |
| #include <map> | ||
| #include <mutex> | ||
| #include <set> | ||
|
|
There was a problem hiding this comment.
warning: included header set is not used directly [misc-include-cleaner]
| #include <set> | ||
|
|
||
| #include "xeus_cpp_config.hpp" | ||
| #include <nlohmann/json.hpp> |
There was a problem hiding this comment.
warning: #includes are not sorted properly [llvm-include-order]
#include <nlohmann/json.hpp>
^this fix will not be applied because it overlaps with another fix
|
|
||
| #include "xeus_cpp_config.hpp" | ||
| #include <nlohmann/json.hpp> | ||
| #include "xeus-zmq/xdebugger_base.hpp" |
There was a problem hiding this comment.
warning: included header json.hpp is not used directly [misc-include-cleaner]
| #include "xeus-zmq/xdebugger_base.hpp" | |
| #include "xeus-zmq/xdebugger_base.hpp" |
| { | ||
| class xllDB_dap_client; | ||
|
|
||
| class XEUS_CPP_API debugger : public xeus::xdebugger_base |
There was a problem hiding this comment.
warning: class 'debugger' defines a destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions]
class XEUS_CPP_API debugger : public xeus::xdebugger_base
^| class XEUS_CPP_API debugger : public xeus::xdebugger_base | ||
| { | ||
| public: | ||
| debugger(xeus::xcontext& context, const xeus::xconfiguration& config, |
There was a problem hiding this comment.
warning: no header providing "xeus::xconfiguration" is directly included [misc-include-cleaner]
include/xeus-cpp/xdebugger.hpp:19:
- #include "xeus-zmq/xdebugger_base.hpp"
+ #include <xeus/xkernel_configuration.hpp>
+ #include "xeus-zmq/xdebugger_base.hpp"| class XEUS_CPP_API debugger : public xeus::xdebugger_base | ||
| { | ||
| public: | ||
| debugger(xeus::xcontext& context, const xeus::xconfiguration& config, |
There was a problem hiding this comment.
warning: no header providing "xeus::xcontext" is directly included [misc-include-cleaner]
include/xeus-cpp/xdebugger.hpp:19:
- #include "xeus-zmq/xdebugger_base.hpp"
+ #include <xeus/xeus_context.hpp>
+ #include "xeus-zmq/xdebugger_base.hpp"| { | ||
| public: | ||
| debugger(xeus::xcontext& context, const xeus::xconfiguration& config, | ||
| const std::string& user_name, const std::string& session_id, |
There was a problem hiding this comment.
warning: no header providing "std::string" is directly included [misc-include-cleaner]
include/xeus-cpp/xdebugger.hpp:19:
- #include "xeus-zmq/xdebugger_base.hpp"
+ #include <string>
+ #include "xeus-zmq/xdebugger_base.hpp"
No description provided.