-
Notifications
You must be signed in to change notification settings - Fork 0
added base files for debugger #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,52 @@ | ||||||
| /************************************************************************************ | ||||||
| * Copyright (c) 2023, xeus-cpp contributors * | ||||||
| * Copyright (c) 2023, Johan Mabille, Loic Gouarin, Sylvain Corlay, Wolf Vollprecht * | ||||||
| * * | ||||||
| * Distributed under the terms of the BSD 3-Clause License. * | ||||||
| * * | ||||||
| * The full license is in the file LICENSE, distributed with this software. * | ||||||
| ************************************************************************************/ | ||||||
|
|
||||||
|
|
||||||
| #ifndef XEUS_CPP_DEBUGGER_HPP | ||||||
| #define XEUS_CPP_DEBUGGER_HPP | ||||||
|
|
||||||
| #include <map> | ||||||
| #include <mutex> | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. warning: included header map is not used directly [misc-include-cleaner]
Suggested change
|
||||||
| #include <set> | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. warning: included header mutex is not used directly [misc-include-cleaner]
Suggested change
|
||||||
|
|
||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. warning: included header set is not used directly [misc-include-cleaner]
Suggested change
|
||||||
| #include "xeus_cpp_config.hpp" | ||||||
| #include <nlohmann/json.hpp> | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. warning: #includes are not sorted properly [llvm-include-order] #include <nlohmann/json.hpp>
^this fix will not be applied because it overlaps with another fix |
||||||
| #include "xeus-zmq/xdebugger_base.hpp" | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. warning: included header json.hpp is not used directly [misc-include-cleaner]
Suggested change
|
||||||
|
|
||||||
| namespace nl = nlohmann; | ||||||
|
|
||||||
| namespace xcpp | ||||||
| { | ||||||
| class xllDB_dap_client; | ||||||
|
|
||||||
| class XEUS_CPP_API debugger : public xeus::xdebugger_base | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. warning: class 'debugger' defines a destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions] class XEUS_CPP_API debugger : public xeus::xdebugger_base
^ |
||||||
| { | ||||||
| public: | ||||||
| debugger(xeus::xcontext& context, const xeus::xconfiguration& config, | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. warning: no header providing "xeus::xconfiguration" is directly included [misc-include-cleaner] include/xeus-cpp/xdebugger.hpp:19: - #include "xeus-zmq/xdebugger_base.hpp"
+ #include <xeus/xkernel_configuration.hpp>
+ #include "xeus-zmq/xdebugger_base.hpp"There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. warning: no header providing "xeus::xcontext" is directly included [misc-include-cleaner] include/xeus-cpp/xdebugger.hpp:19: - #include "xeus-zmq/xdebugger_base.hpp"
+ #include <xeus/xeus_context.hpp>
+ #include "xeus-zmq/xdebugger_base.hpp" |
||||||
| const std::string& user_name, const std::string& session_id, | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. warning: no header providing "std::string" is directly included [misc-include-cleaner] include/xeus-cpp/xdebugger.hpp:19: - #include "xeus-zmq/xdebugger_base.hpp"
+ #include <string>
+ #include "xeus-zmq/xdebugger_base.hpp" |
||||||
| const nl::json& lldb_config); | ||||||
|
|
||||||
| virtual ~debugger(); | ||||||
|
|
||||||
| private: | ||||||
| bool start() override; | ||||||
| void stop() override; | ||||||
| xeus::xdebugger_info get_debugger_info() const override; | ||||||
| std::string get_cell_temporary_file(const std::string& code) const override; | ||||||
|
|
||||||
| private: | ||||||
| xllDB_dap_client* p_lldb_dap_client; | ||||||
| std::string m_lldb_host{"localhost"}; | ||||||
| std::string m_lldb_port{"12345"}; | ||||||
| nl::json m_lldb_config; | ||||||
| }; | ||||||
| std::unique_ptr<xeus::xdebugger> make_cpp_debugger(...); | ||||||
| } | ||||||
|
|
||||||
| #endif | ||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| /************************************************************************************ | ||
| * Copyright (c) 2023, xeus-cpp contributors * | ||
| * Copyright (c) 2023, Johan Mabille, Loic Gouarin, Sylvain Corlay, Wolf Vollprecht * | ||
| * * | ||
| * Distributed under the terms of the BSD 3-Clause License. * | ||
| * * | ||
| * The full license is in the file LICENSE, distributed with this software. * | ||
| ************************************************************************************/ | ||
|
|
||
|
|
||
| #include "xeus-cpp/xdebugger.hpp" | ||
| #include "xeus-zmq/xmiddleware.hpp" | ||
| #include "xeus/xinterpreter.hpp" | ||
| #include "xeus/xsystem.hpp" | ||
| #include "xeus-zmq/xmiddleware.hpp" | ||
|
|
||
| namespace xcpp | ||
| { | ||
| debugger::debugger(xeus::xcontext& context, const xeus::xconfiguration& config, | ||
| const std::string& user_name, const std::string& session_id, | ||
| const nl::json& lldb_config) | ||
| : xdebugger_base(context) | ||
| , p_lldb_dap_client(nullptr) | ||
| , m_lldb_host("localhost") | ||
| , m_lldb_port("12345") | ||
| , m_lldb_config(lldb_config) | ||
| { | ||
| } | ||
|
|
||
| debugger::~debugger() | ||
| { | ||
| // delete p_lldb_dap_client; | ||
| // p_lldb_dap_client = nullptr; | ||
| } | ||
|
|
||
| bool debugger::start() | ||
| { | ||
| return true; | ||
| } | ||
|
|
||
| void debugger::stop() | ||
| { | ||
| return; | ||
| } | ||
|
|
||
| xeus::xdebugger_info debugger::get_debugger_info() const | ||
| { | ||
| // return temporary values | ||
| return xeus::xdebugger_info(1, | ||
| "temp_prefix", | ||
| "temp_suffix", | ||
| true, | ||
| {"Temporary Exceptions"}, | ||
| true); | ||
| } | ||
|
|
||
| std::string debugger::get_cell_temporary_file(const std::string& code) const | ||
| { | ||
| return ""; | ||
| } | ||
|
|
||
| std::unique_ptr<xeus::xdebugger> make_cpp_debugger(xeus::xcontext& context, | ||
| const xeus::xconfiguration& config, | ||
| const std::string& user_name, | ||
| const std::string& session_id, | ||
| const nl::json& lldb_config) | ||
| { | ||
| return std::unique_ptr<xeus::xdebugger>(new debugger(context, config, user_name, session_id, lldb_config)); | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: header guard does not follow preferred style [llvm-header-guard]