FEAT:Add ARIA labels fixed and added#72
FEAT:Add ARIA labels fixed and added#72bhavish-codes wants to merge 1 commit intokrushndayshmookh:mainfrom
Conversation
WalkthroughThis pull request adds ARIA accessibility labels ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/components/layout/LayoutDrawerApplet.vue (1)
13-13: Good dynamic ARIA label for state changes.The aria-label correctly reflects whether the applet is expanded or collapsed, improving accessibility for screen reader users.
Consider using template literals for cleaner string composition:
- :aria-label="(isVisible ? 'Collapse' : 'Expand') + ' ' + name + ' applet'" + :aria-label="`${isVisible ? 'Collapse' : 'Expand'} ${name} applet`"src/components/layout/LayoutButton.vue (1)
10-10: ARIA label implementation with icon fallback.The fallback to
iconwhenariaLabelis not provided is functional, though icon names (e.g., "eva-arrowhead-left-outline") aren't ideal for screen readers. Since parent components are providing proper labels (as seen in EditorLayout.vue), this fallback is acceptable.For future consideration, you might want to make
ariaLabelrequired or provide a more user-friendly default to ensure all buttons have meaningful labels.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
src/components/applets/AppletLayers.vue(1 hunks)src/components/editor/EditorTimeline.vue(1 hunks)src/components/editor/EditorToolbar.vue(1 hunks)src/components/layout/LayoutButton.vue(2 hunks)src/components/layout/LayoutDrawerApplet.vue(1 hunks)src/layouts/EditorLayout.vue(1 hunks)
🔇 Additional comments (5)
src/components/editor/EditorToolbar.vue (1)
11-11: LGTM! Good accessibility improvement.The aria-label binding with a fallback from
item.tooltiptoitem.nameensures toolbar buttons are properly labeled for screen readers.src/layouts/EditorLayout.vue (1)
10-10: LGTM! Excellent accessibility enhancement.The aria-labels clearly describe the toggle actions for each panel, making the interface more accessible to screen reader users.
Also applies to: 18-18, 26-26
src/components/editor/EditorTimeline.vue (1)
33-33: LGTM! Important accessibility improvement for form inputs.The aria-labels provide clear descriptions of the timeline input fields for assistive technologies.
Also applies to: 41-41, 49-49
src/components/applets/AppletLayers.vue (1)
21-21: LGTM! Contextual ARIA label with appropriate fallback.The aria-label effectively communicates which node the actions menu belongs to, with a sensible fallback from
idtotagName.src/components/layout/LayoutButton.vue (1)
31-34: Good addition of ariaLabel prop for accessibility.The new prop enables parent components to provide descriptive ARIA labels.
Hi Sir I have added ARIA LABEL pls merge my PR after reviewing it
Summary by CodeRabbit