Skip to content

FEAT:Add ARIA labels fixed and added #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bhavish-codes wants to merge 1 commit into
base: main
Choose a base branch
from
Open

FEAT:Add ARIA labels fixed and added #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/applets/AppletLayers.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
flat
round
icon="eva-more-vertical"
:aria-label="'Open actions for ' + (prop.node.id || prop.node.tagName)"
class="q-ml-auto"
:disable="prop.node.id === 'svg-root'"
>
Expand Down
3 changes: 3 additions & 0 deletions src/components/editor/EditorTimeline.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,20 +30,23 @@
:data-test="'timeline-anim-from-' + row.animIndex"
type="text"
placeholder="from"
aria-label="From value"
/>
<input
v-model="edits[idKey(row)].to"
class="q-input q-field__native"
:data-test="'timeline-anim-to-' + row.animIndex"
type="text"
placeholder="to"
aria-label="To value"
/>
<input
v-model="edits[idKey(row)].dur"
class="q-input q-field__native"
:data-test="'timeline-anim-dur-' + row.animIndex"
type="text"
placeholder="dur"
aria-label="Duration"
/>
<q-btn
dense
Expand Down
1 change: 1 addition & 0 deletions src/components/editor/EditorToolbar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
:flat="!item.isActive"
dense
:icon="item.icon"
:aria-label="item.tooltip || item.name"
:style="{
transform: item.iconFlip ? 'scaleX(-1)' : 'none',
}"
Expand Down
9 changes: 6 additions & 3 deletions src/components/layout/LayoutButton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
:color="active ? 'white' : ''"
:text-color="active ? 'primary' : ''"
:icon="icon"
:aria-label="ariaLabel || icon"
:data-test="dataTest"
class="q-mx-xs"
@click="$emit('click')"
Expand All @@ -27,11 +28,13 @@ defineProps({
type: String,
default: '',
},
ariaLabel: {
type: String,
default: '',
},
})

defineEmits(['click'])
</script>

<style scoped>

</style>
<style scoped></style>
1 change: 1 addition & 0 deletions src/components/layout/LayoutDrawerApplet.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
flat
round
:icon="isVisible ? 'keyboard_arrow_up' : 'keyboard_arrow_down'"
:aria-label="(isVisible ? 'Collapse' : 'Expand') + ' ' + name + ' applet'"
@click="toggle"
/>
</q-item-section>
Expand Down
3 changes: 3 additions & 0 deletions src/layouts/EditorLayout.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,20 +7,23 @@
<LayoutButton
:active="editorStore.sidebarLeftOpen"
icon="eva-arrowhead-left-outline"
aria-label="Toggle left panel"
data-test="toolbar-toggle-left"
@click="editorStore.toggleSidebarLeft"
/>

<LayoutButton
:active="editorStore.sidebarRightOpen"
icon="eva-arrowhead-right-outline"
aria-label="Toggle right panel"
data-test="toolbar-toggle-right"
@click="editorStore.toggleSidebarRight"
/>

<LayoutButton
:active="editorStore.sidebarBottomOpen"
icon="eva-arrowhead-down-outline"
aria-label="Toggle bottom panel"
data-test="toolbar-toggle-bottom"
@click="editorStore.toggleSidebarBottom"
/>
Expand Down