Open
Conversation
Having a blank string password is not recommended for cases when user should be explicitely marked as having no password. This is exactly the recommended way that is used when the authentication for the application takes place outside.
Right now feature of creating users aren't very useful, since it doesn't allow to set additional parameters on the user and most of developers have to create users in response callbacks. With this simple fix, we return the power to the settings CAS_AUTO_CREATE_USER, so users can set it and build their custom middleware by inheritance.
gakhov
changed the title
stsewd
approved these changes
May 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having a blank string password is not recommended for cases
when the user should be explicitly marked as having no password.
This is exactly the recommended way that is used when the
authentication for the application takes place outside.
Right now the feature of creating users aren't very useful, since
it doesn't allow to set additional parameters on the user and
most of the developers have to create users in response callbacks.
With this simple fix, we return the power to the settings
CAS_AUTO_CREATE_USER, so users can set it and build their custom
middleware by inheritance.