Improve the user auto-creation flow

cas/backends.py

@@ -236,9 +236,9 @@ def authenticate(self, request, ticket, service):
         try:
             user = User.objects.get(username__iexact=username)
         except User.DoesNotExist:
-            # user will have an "unusable" password
             if settings.CAS_AUTO_CREATE_USER:
-                user = User.objects.create_user(username, '')
+                user = User.objects.create_user(username)
+                user = self.configure_user(user)
                 user.save()
             else:
                 user = None
@@ -255,3 +255,10 @@ def get_user(self, user_id):
             return User.objects.get(pk=user_id)
         except User.DoesNotExist:
             return None
+
+    def configure_user(self, user):
+        """
+        Configures newly created user.
+        """
+        user.set_unusable_password()
+        return user

cas/tests/factories.py

@@ -12,4 +12,4 @@ class Meta:
     first_name = "new"
     last_name = "user"
     is_staff = True
-    password = factory.PostGenerationMethodCall('set_password', '1234')
+    password = factory.PostGenerationMethodCall('set_unusable_password')