Skip to content

Conversation

@RavinduWeerakoon
Copy link
Contributor

This allows users to install newer versions of Click while maintaining compatibility with the SDK.

Fixes #12361

@google-oss-prow
Copy link

Hi @RavinduWeerakoon. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

🚫 This command cannot be processed. Only organization members or owners can use the commands.

@HumairAK
Copy link
Collaborator

HumairAK commented Oct 21, 2025

thanks @RavinduWeerakoon can you rebase and sign off your commit (so it passes the DCO check)

@HumairAK HumairAK marked this pull request as ready for review October 21, 2025 14:17
@google-oss-prow google-oss-prow bot requested a review from zazulam October 21, 2025 14:17
@HumairAK HumairAK requested review from HumairAK and removed request for DharmitD, droctothorpe and zazulam October 21, 2025 14:17
@RavinduWeerakoon
Copy link
Contributor Author

@HumairAK Done .

@HumairAK
Copy link
Collaborator

@RavinduWeerakoon the commits are still not signed, can you squash and sign them? git commit -s, the commit should have a line that says Signed-off-by: Author Name <[email protected]> and the DCO ci check needs to pass

@RavinduWeerakoon
Copy link
Contributor Author

@HumairAK thanks. I squashed the commits and signed them. The sign-off message is showing now

@RavinduWeerakoon
Copy link
Contributor Author

RavinduWeerakoon commented Oct 25, 2025

@HumairAK, any update on this? The DCO is now okay. Sorry, I thought the DCO also needed approval to run, and that's why it shows the error

@HumairAK
Copy link
Collaborator

thanks @RavinduWeerakoon this is good!

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 71d1296 into kubeflow:master Oct 27, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(sdk): allow installing click > 8.1.8

2 participants