-
Notifications
You must be signed in to change notification settings - Fork 1.8k
chore(sdk) : Allow installation of newer python click versions Fixes #12361 #12367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sdk) : Allow installation of newer python click versions Fixes #12361 #12367
Conversation
|
Hi @RavinduWeerakoon. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
🚫 This command cannot be processed. Only organization members or owners can use the commands. |
|
thanks @RavinduWeerakoon can you rebase and sign off your commit (so it passes the DCO check) |
392086e to
09888b5
Compare
|
@HumairAK Done . |
|
@RavinduWeerakoon the commits are still not signed, can you squash and sign them? |
09888b5 to
19376ce
Compare
|
@HumairAK thanks. I squashed the commits and signed them. The sign-off message is showing now |
11e2f8d to
da16176
Compare
|
@HumairAK, any update on this? The DCO is now okay. Sorry, I thought the DCO also needed approval to run, and that's why it shows the error |
Signed-off-by: Ravindu Weerakoon <[email protected]>
da16176 to
9d75fa3
Compare
|
thanks @RavinduWeerakoon this is good! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This allows users to install newer versions of Click while maintaining compatibility with the SDK.
Fixes #12361