test: handle process.env in config_test.ts #2294
Conversation
k8s-ci-robot
added
approved
cjihrig
requested review from
Copilot
and removed request for
brendandburns and
davidgamero
k8s-ci-robot
added
the
size/S
There was a problem hiding this comment.
PR Overview
This PR addresses issues with tests failing due to unexpected environment variables by isolating environment values during test execution. Key changes include storing the original environment variables, replacing process.env with an empty object for testing, and restoring process.env after tests complete.
Reviewed Changes
| File | Description |
|---|---|
| src/config_test.ts | Updated test hooks to shield tests from external process.env values |
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
| before(() => { | ||
| // The code being tested here references process.env and can fail | ||
| // if run on a machine with certain environment variable settings. | ||
| originalEnv = process.env; |
There was a problem hiding this comment.
Assigning process.env directly to originalEnv stores a reference instead of a snapshot, which may lead to unintended side effects. Consider using a shallow copy (e.g., originalEnv = { ...process.env }) to ensure the original environment is accurately restored.
| originalEnv = process.env; | |
| originalEnv = { ...process.env }; |
Copilot uses AI. Check for mistakes.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
The tests in kubernetes-client#2288 can fail depending on the environment variables on the system. This commit takes the environment out of the equation. Refs: kubernetes-client#2288
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, cjihrig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
The tests in #2288 can fail depending on the environment variables on the system. This commit takes the environment out of the equation.
Refs: #2288