Skip to content

test: handle process.env in config_test.ts #2294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025
+13 −0
Merged

test: handle process.env in config_test.ts #2294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/config_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1613,6 +1613,19 @@ describe('KubeConfig', () => {
});

describe('BufferOrFile', () => {
let originalEnv;

before(() => {
// The code being tested here references process.env and can fail
// if run on a machine with certain environment variable settings.
originalEnv = process.env;
Copy link

Copilot AI Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assigning process.env directly to originalEnv stores a reference instead of a snapshot, which may lead to unintended side effects. Consider using a shallow copy (e.g., originalEnv = { ...process.env }) to ensure the original environment is accurately restored.

Suggested change
originalEnv = process.env;
originalEnv = { ...process.env };

Copilot uses AI. Check for mistakes.

process.env = {};
});

after(() => {
process.env = originalEnv;
});

it('should load from root if present', () => {
const data = 'some data for file';
const arg: any = {
Expand Down