-
Notifications
You must be signed in to change notification settings - Fork 557
abort signal support via regenerating on new openapigen commit #2583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
abort signal support via regenerating on new openapigen commit #2583
Conversation
486d612
to
3d9b7d6
Compare
666e321
to
a789a30
Compare
a789a30
to
1490801
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove this part from the tsconfig-with-tests.json
and tsconfig.json
files?
"paths": {
"node-fetch/externals": ["./node_modules/@types/node-fetch/externals.d.ts"]
}
https://github.com/kubernetes-client/javascript/blob/main/tsconfig-with-tests.json#L4-L8
https://github.com/kubernetes-client/javascript/blob/main/tsconfig.json#L20-L22
I think it should work without now.
yes done |
/lgtm Thanks 🚀 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidgamero, mstruebing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can we expect a 1.4.0 release soon with this new feature included? Would be useful to us (no pressure though!) :) |
We want to release a new version with the new kubernetes update, maybe even v2.0.0 based on the discussion here: #2582 I've tried to prepare a release and regenerate the client with release-1.34 as it's finally there but it failed as there is nothing to commit here: https://github.com/kubernetes-client/javascript/actions/runs/17399794124 @davidgamero did you already regenerate the client with release-1.34? |
addresses configuration timeout support from #2430 by allowing timeout signal into generated client code