do not generate snapshotter container if enabled: false

[alexgaganashvili]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
Do not include snapshotter container unless .externalSnapshotter.enabled is true

Does this PR introduce a user-facing change?:

none

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alexgaganashvili
Once this PR has been reviewed and has the lgtm label, please assign jsafrane for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @alexgaganashvili!

It looks like this is your first PR to kubernetes-csi/csi-driver-nfs 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-driver-nfs has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @alexgaganashvili. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[andyzhangx]

we have already controller.enableSnapshotter to control this, and even snapshot controller is disabled, some users still need this snapshotter container to run there:

csi-driver-nfs/charts/latest/csi-driver-nfs/values.yaml

Line 59 in 49570c7

enableSnapshotter: true

[alexgaganashvili]

If I don't need it, I can just set the resources to minimum, I guess? How do I know if I need the container to run, since I disable the snapshot controller itself during helm install?

[andyzhangx]

if you don't want snapshot functionality, then you could set controller.enableSnapshotter as false

[alexgaganashvili]

But the snapshotter container will still be included. I'm not sure why I need it there by default.

[andyzhangx]

the change is made in https://github.com/kubernetes-csi/csi-driver-nfs/pull/820/files, in next released version, you could use --set controller.enableSnapshotter=false to disable snapshotter container