Skip to content

do not generate snapshotter container if enabled: false #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

do not generate snapshotter container if enabled: false #830

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions charts/v4.9.0/csi-driver-nfs/templates/csi-nfs-controller.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ spec:
capabilities:
drop:
- ALL
{{- if .Values.externalSnapshotter.enabled }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have already controller.enableSnapshotter to control this, and even snapshot controller is disabled, some users still need this snapshotter container to run there:

csi-driver-nfs/charts/latest/csi-driver-nfs/values.yaml

Line 59 in 49570c7

enableSnapshotter: true

Copy link
Author

@alexgaganashvili alexgaganashvili Dec 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I don't need it, I can just set the resources to minimum, I guess? How do I know if I need the container to run, since I disable the snapshot controller itself during helm install?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you don't want snapshot functionality, then you could set controller.enableSnapshotter as false

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the snapshotter container will still be included. I'm not sure why I need it there by default.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change is made in https://github.com/kubernetes-csi/csi-driver-nfs/pull/820/files, in next released version, you could use --set controller.enableSnapshotter=false to disable snapshotter container

- name: csi-snapshotter
{{- if hasPrefix "/" .Values.image.csiSnapshotter.repository }}
image: "{{ .Values.image.baseRepo }}{{ .Values.image.csiSnapshotter.repository }}:{{ .Values.image.csiSnapshotter.tag }}"
Expand All @@ -110,6 +111,7 @@ spec:
capabilities:
drop:
- ALL
{{- end }}
- name: liveness-probe
{{- if hasPrefix "/" .Values.image.livenessProbe.repository }}
image: "{{ .Values.image.baseRepo }}{{ .Values.image.livenessProbe.repository }}:{{ .Values.image.livenessProbe.tag }}"
Expand Down
Loading