-
Notifications
You must be signed in to change notification settings - Fork 153
feat: Add driver.labels option to helm chart for CSIDriver resource #998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @Copilot. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Co-authored-by: andyzhangx <[email protected]>
Co-authored-by: andyzhangx <[email protected]>
Co-authored-by: andyzhangx <[email protected]>
Added |
andyzhangx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
Pull Request Test Coverage Report for Build 19825375482Details
💛 - Coveralls |
andyzhangx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, Copilot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds
driver.labelsoption to the helm chart, enabling custom labels on the CSIDriver resource.This is needed for OpenShift environments where ephemeral CSI volumes require the
security.openshift.io/csi-ephemeral-volume-profilelabel to use therestrictedsecurity profile instead of the defaultprivilegedprofile.Changes:
driver.labels: {}tovalues.yamlcsi-smb-driver.yamltemplate to conditionally render labelsdriver.labelsexample toE2E_HELM_OPTIONSin Makefile for e2e testingUsage:
Or via CLI:
Which issue(s) this PR fixes:
Fixes #988
Requirements:
Special notes for your reviewer:
Pattern follows existing
podLabelsimplementation. No labels rendered whendriver.labelsis empty (default).Release note:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.