Skip to content

feat: Add driver.labels option to helm chart for CSIDriver resource #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 2, 2025
+6 −1
Merged

feat: Add driver.labels option to helm chart for CSIDriver resource #998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9adad1c
Initial plan
Copilot Dec 1, 2025
dfbfe92
Add driver.labels option to helm chart for CSIDriver labels
Copilot Dec 1, 2025
b7c184f
Use nindent instead of indent for driver.labels in csi-smb-driver.yaml
Copilot Dec 1, 2025
f338d12
Add driver.labels example to E2E_HELM_OPTIONS for e2e testing
Copilot Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ BUILD_DATE := $(shell date -u +"%Y-%m-%dT%H:%M:%SZ")
endif
LDFLAGS = -X ${PKG}/pkg/smb.driverVersion=${IMAGE_VERSION} -X ${PKG}/pkg/smb.gitCommit=${GIT_COMMIT} -X ${PKG}/pkg/smb.buildDate=${BUILD_DATE}
EXT_LDFLAGS = -s -w -extldflags "-static"
E2E_HELM_OPTIONS ?= --set image.smb.repository=$(REGISTRY)/$(IMAGENAME) --set image.smb.tag=$(IMAGE_VERSION) --set controller.runOnControlPlane=true
E2E_HELM_OPTIONS ?= --set image.smb.repository=$(REGISTRY)/$(IMAGENAME) --set image.smb.tag=$(IMAGE_VERSION) --set controller.runOnControlPlane=true --set driver.labels.testlabel=testvalue
E2E_HELM_OPTIONS += ${EXTRA_HELM_OPTIONS}
# Generate all combination of all OS, ARCH, and OSVERSIONS for iteration
ALL_OS = linux windows
Expand Down
Binary file modified charts/latest/csi-driver-smb-v0.0.0.tgz
View file
Open in desktop
Binary file not shown.
4 changes: 4 additions & 0 deletions charts/latest/csi-driver-smb/templates/csi-smb-driver.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ apiVersion: storage.k8s.io/v1
kind: CSIDriver
metadata:
name: {{ .Values.driver.name }}
{{- if .Values.driver.labels }}
labels:
{{- toYaml .Values.driver.labels | nindent 4 }}
{{- end }}
spec:
attachRequired: false
podInfoOnMount: true
Expand Down
1 change: 1 addition & 0 deletions charts/latest/csi-driver-smb/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ rbac:

driver:
name: smb.csi.k8s.io
labels: {}

feature:
enableGetVolumeStats: true
Expand Down
Loading