fix(dashboards): fix USE Method / Node(Windows) dashboard
#1013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stance` variable and other small fixes
skl
reviewed
Jan 30, 2025
| (import 'node.libsonnet') + | ||
| (import 'kubelet.libsonnet') | ||
| (import 'kubelet.libsonnet') + | ||
| (import 'windows.libsonnet') |
There was a problem hiding this comment.
@povilasv this would add windows rules and dashboards into the default build - are you ok with that? Personally, I see no harm in including them but wanted to check with you.
There was a problem hiding this comment.
will merge Monday @povilasv unless I hear otherwise 😄 can always revert this part in future
| prometheus.new( | ||
| '${datasource}', | ||
| 'max(rate(windows_logical_disk_read_seconds_total{%(clusterLabel)s="$cluster", %(windowsExporterSelector)s, instance="$instance"}[2m]) + rate(windows_logical_disk_write_seconds_total{%(clusterLabel)s="$cluster", %(windowsExporterSelector)s, instance="$instance"}[2m]))' % $._config | ||
| 'max(rate(windows_logical_disk_read_seconds_total{%(clusterLabel)s="$cluster", %(windowsExporterSelector)s, instance="$instance"}[%(grafanaIntervalVar)s]) + rate(windows_logical_disk_write_seconds_total{%(clusterLabel)s="$cluster", %(windowsExporterSelector)s, instance="$instance"}[%(grafanaIntervalVar)s]))' % $._config |
There was a problem hiding this comment.
Thanks for these additional changes 👍
| + var.query.refresh.onTime() | ||
| + var.query.generalOptions.showOnDashboard.withLabelAndValue() | ||
| + var.query.selectionOptions.withMulti(true), | ||
| + var.query.generalOptions.showOnDashboard.withLabelAndValue(), |
There was a problem hiding this comment.
This would seem to resolve the linked issue - thank you!
skl
approved these changes
Feb 3, 2025
4 tasks
rexagod
pushed a commit
to rexagod/kubernetes-mixin
that referenced
this pull request
Feb 10, 2025
…stance` variable and other small fixes (kubernetes-monitoring#1013)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disabling
Multi-valueselection option for theinstancevariable and other small fixes. (#980)