fix(KubeletTooManyPods): handle inconsistent instance labels #1021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
rexagod
pushed a commit
to rexagod/kubernetes-mixin
that referenced
this pull request
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out there's a variety of Kubelet scrape configurations out there:
instancelabel as node IP address, others use this label as the node namenodelabel as the name name, others don't have this labelkubelet_node_namedoes have anodelabel which seems a consistent source of the node nameThis PR updates the
KubeletTooManyPodsalert to source the node name fromkubelet_node_nameand updates the tests to represent the inconsistent scrape configs.Fixes #1015