Skip to content

fix(KubeletTooManyPods): handle inconsistent instance labels #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2025
Merged

fix(KubeletTooManyPods): handle inconsistent instance labels #1021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions alerts/kubelet.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,16 @@ local utils = import '../lib/utils.libsonnet';
// Some node has a capacity of 1 like AWS's Fargate and only exists while a pod is running on it.
// We have to ignore this special node in the KubeletTooManyPods alert.
expr: |||
max by (cluster, node) (
label_replace(kubelet_running_pods{%(kubeletSelector)s} > 1, "node", "$1", "instance", "(.*)")
(
max by (cluster, instance) (
kubelet_running_pods{%(kubeletSelector)s} > 1
)
* on (cluster, instance) group_left(node)
max by (cluster, instance, node) (
kubelet_node_name{%(kubeletSelector)s}
)
)
/
/ on (cluster, node) group_left()
max by (%(clusterLabel)s, node) (
kube_node_status_capacity{%(kubeStateMetricsSelector)s, resource="pods"} != 1
) > 0.95
Expand Down
14 changes: 11 additions & 3 deletions tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,11 +403,13 @@ tests:
- eval_time: 61m
alertname: KubePersistentVolumeInodesFillingUp

- name: KubeletTooManyPods alert (single-node)
- name: KubeletTooManyPods alert (single-node with instance as IP address)
interval: 1m
input_series:
- series: 'kubelet_running_pods{cluster="kubernetes", instance="node0", job="kubelet"}'
- series: 'kubelet_running_pods{cluster="kubernetes", instance="10.0.0.0", job="kubelet"}'
values: '3x15'
- series: 'kubelet_node_name{cluster="kubernetes", instance="10.0.0.0", node="node0", job="kubelet"}'
values: '1x15'
- series: 'kube_node_status_capacity{cluster="kubernetes", node="node0", job="kube-state-metrics", resource="pods", unit="integer"}'
values: '3x15'
alert_rule_test:
Expand All @@ -418,22 +420,27 @@ tests:
exp_alerts:
- exp_labels:
cluster: kubernetes
instance: 10.0.0.0
node: node0
severity: info
exp_annotations:
summary: "Kubelet is running at capacity."
description: "Kubelet 'node0' is running at 100% of its Pod capacity."
runbook_url: https://github.com/kubernetes-monitoring/kubernetes-mixin/tree/master/runbook.md#alert-name-kubelettoomanypods

- name: KubeletTooManyPods alert (multi-node)
- name: KubeletTooManyPods alert (multi-node with instance as node name)
interval: 1m
input_series:
- series: 'kubelet_running_pods{cluster="kubernetes", instance="node0", job="kubelet"}'
values: '3x15'
- series: 'kubelet_node_name{cluster="kubernetes", instance="node0", node="node0", job="kubelet"}'
values: '1x15'
- series: 'kube_node_status_capacity{cluster="kubernetes", node="node0", job="kube-state-metrics", resource="pods", unit="integer"}'
values: '6x15'
- series: 'kubelet_running_pods{cluster="kubernetes", instance="node1", job="kubelet"}'
values: '3x15'
- series: 'kubelet_node_name{cluster="kubernetes", instance="node1", node="node1", job="kubelet"}'
values: '1x15'
- series: 'kube_node_status_capacity{cluster="kubernetes", node="node1", job="kube-state-metrics", resource="pods", unit="integer"}'
values: '3x15'
alert_rule_test:
Expand All @@ -444,6 +451,7 @@ tests:
exp_alerts:
- exp_labels:
cluster: kubernetes
instance: node1
node: node1
severity: info
exp_annotations:
Expand Down