fix mounting volumes with FIPS enabled

[h0tw1r3]

Is this a bug fix or adding new feature?

Bug

What is this PR about? / Why do we need it?

The documentation suggests setting useFIPS: true is sufficient to ensure mounts are made using FIPS crypto, but it is not.

Using EKS cluster addons, passing the useFIPS configuration does nothing but ensure AWS API calls are bould by FIPS.

What testing is done?

Working on it. Floating to get feedback.

[linux-foundation-easycla]

• ✅login: h0tw1r3 / (7e87c9f)

The committers listed above are authorized under a signed CLA.

[k8s-ci-robot]

Welcome @h0tw1r3!

It looks like this is your first PR to kubernetes-sigs/aws-efs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-efs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: h0tw1r3
Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @h0tw1r3. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[dankova22]

The current implementation should work because efs-utils checks for FIPS in two ways:

-Through the AWS_USE_FIPS_ENDPOINT environment variable (which is currently set by the Helm chart)
-Through the fips_mode_enabled setting in the config file

https://github.com/aws/efs-utils/blob/master/src/mount_efs/__init__.py#L3474-L3478
The current Helm chart sets AWS_USE_FIPS_ENDPOINT=true when useFIPS is enabled, which should be sufficient

However, this change does add redundancy for both ways

[wangnyue]

+1 . I think the real bug is in Readme. it need --set useFIPS=true instead of --set useFips=true

[dankova22]

Updated the documentation for proper capitalization: #1644. We are still evaluating if using the same helm value to also update the config file makes sense.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle rotten
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten