Skip to content

fix mounting volumes with FIPS enabled #1636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −1
Open

fix mounting volumes with FIPS enabled #1636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions charts/aws-efs-csi-driver/templates/controller-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,8 @@ spec:
{{- if .Values.useFIPS }}
- name: AWS_USE_FIPS_ENDPOINT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current implementation should work because efs-utils checks for FIPS in two ways:

-Through the AWS_USE_FIPS_ENDPOINT environment variable (which is currently set by the Helm chart)
-Through the fips_mode_enabled setting in the config file

https://github.com/aws/efs-utils/blob/master/src/mount_efs/__init__.py#L3474-L3478
The current Helm chart sets AWS_USE_FIPS_ENDPOINT=true when useFIPS is enabled, which should be sufficient

However, this change does add redundancy for both ways

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 . I think the real bug is in Readme. it need --set useFIPS=true instead of --set useFips=true

value: "true"
- name: FIPS_ENABLED
value: "true"
{{- end }}
- name: PORT_RANGE_UPPER_BOUND
value: "{{ .Values.portRangeUpperBound }}"
Expand Down
2 changes: 2 additions & 0 deletions charts/aws-efs-csi-driver/templates/node-daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,8 @@ spec:
{{- if .Values.useFIPS }}
- name: AWS_USE_FIPS_ENDPOINT
value: "true"
- name: FIPS_ENABLED
value: "true"
{{- end }}
- name: PORT_RANGE_UPPER_BOUND
value: "{{ .Values.portRangeUpperBound }}"
Expand Down
2 changes: 1 addition & 1 deletion docs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ This procedure requires Helm V3 or later. To install or upgrade Helm, see [Using

To force the Amazon EFS CSI driver to use FIPS for mounting the file system, add the following argument.
```sh
--set useFips=true
--set useFIPS=true
```
**Note**
`hostNetwork: true` (should be added under spec/deployment on kubernetes installations where AWS metadata is not reachable from pod network. To fix the following error `NoCredentialProviders: no valid providers in chain` this parameter should be added.)
Expand Down