[release-1.32] fix: create volume failure when requested pvc size is smaller than snapshot disk size #3395

[priyansh17]

This is a cherry-pick of #3379

/assign andyzhangx

[k8s-ci-robot]

Hi @priyansh17. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[andyzhangx]

/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, priyansh17

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [andyzhangx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@priyansh17: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-azuredisk-csi-driver-verify	d069037	link	true	/test pull-azuredisk-csi-driver-verify
pull-azuredisk-csi-driver-unit	d069037	link	true	/test pull-azuredisk-csi-driver-unit
pull-azuredisk-csi-driver-external-e2e-single-az	d069037	link	true	/test pull-azuredisk-csi-driver-external-e2e-single-az

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[andyzhangx]

@priyansh17 can you fix the ut failure?

=== RUN   TestCreateVolume/create_managed_disk_error_
I1104 06:46:49.177169   13453 driver.go:82] Enabling controller service capability: CREATE_DELETE_VOLUME
I1104 06:46:49.177176   13453 driver.go:82] Enabling controller service capability: PUBLISH_UNPUBLISH_VOLUME
I1104 06:46:49.177178   13453 driver.go:82] Enabling controller service capability: CREATE_DELETE_SNAPSHOT
I1104 06:46:49.177179   13453 driver.go:82] Enabling controller service capability: LIST_SNAPSHOTS
I1104 06:46:49.177181   13453 driver.go:82] Enabling controller service capability: CLONE_VOLUME
I1104 06:46:49.177182   13453 driver.go:82] Enabling controller service capability: EXPAND_VOLUME
I1104 06:46:49.177183   13453 driver.go:82] Enabling controller service capability: LIST_VOLUMES
I1104 06:46:49.177184   13453 driver.go:82] Enabling controller service capability: LIST_VOLUMES_PUBLISHED_NODES
I1104 06:46:49.177185   13453 driver.go:82] Enabling controller service capability: MODIFY_VOLUME
I1104 06:46:49.177187   13453 driver.go:101] Enabling volume access mode: SINGLE_NODE_WRITER
I1104 06:46:49.177223   13453 controllerserver.go:119] increasing requested disk size from 0GiB to 1GiB (minimal disk size)
W1104 06:46:49.177230   13453 controllerserver.go:1371] could not get subscription id, resource group from snapshot uri (unit-test) with error(invalid URI: unit-test)
    controllerserver_test.go:353: actualErr: (rpc error: code = NotFound desc = invalid URI: unit-test), expectedErr: (rpc error: code = Internal desc = test)
=== RUN   TestCreateVolume/create_managed_disk_not_found_error_

[priyansh17]

@priyansh17 can you fix the ut failure?

=== RUN   TestCreateVolume/create_managed_disk_error_

I1104 06:46:49.177169   13453 driver.go:82] Enabling controller service capability: CREATE_DELETE_VOLUME

I1104 06:46:49.177176   13453 driver.go:82] Enabling controller service capability: PUBLISH_UNPUBLISH_VOLUME

I1104 06:46:49.177178   13453 driver.go:82] Enabling controller service capability: CREATE_DELETE_SNAPSHOT

I1104 06:46:49.177179   13453 driver.go:82] Enabling controller service capability: LIST_SNAPSHOTS

I1104 06:46:49.177181   13453 driver.go:82] Enabling controller service capability: CLONE_VOLUME

I1104 06:46:49.177182   13453 driver.go:82] Enabling controller service capability: EXPAND_VOLUME

I1104 06:46:49.177183   13453 driver.go:82] Enabling controller service capability: LIST_VOLUMES

I1104 06:46:49.177184   13453 driver.go:82] Enabling controller service capability: LIST_VOLUMES_PUBLISHED_NODES

I1104 06:46:49.177185   13453 driver.go:82] Enabling controller service capability: MODIFY_VOLUME

I1104 06:46:49.177187   13453 driver.go:101] Enabling volume access mode: SINGLE_NODE_WRITER

I1104 06:46:49.177223   13453 controllerserver.go:119] increasing requested disk size from 0GiB to 1GiB (minimal disk size)

W1104 06:46:49.177230   13453 controllerserver.go:1371] could not get subscription id, resource group from snapshot uri (unit-test) with error(invalid URI: unit-test)

    controllerserver_test.go:353: actualErr: (rpc error: code = NotFound desc = invalid URI: unit-test), expectedErr: (rpc error: code = Internal desc = test)

=== RUN   TestCreateVolume/create_managed_disk_not_found_error_

Sure, will update.