Skip to content

Conversation

matzegebbe
Copy link
Contributor

@matzegebbe matzegebbe commented Jun 3, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds support for Amazon Linux 2023 AMI lookup in the EKS optimized AMI workflow. It ensures compatibility with the latest Amazon Linux 2023 and its GPU variant, enabling users to leverage these AMIs for their EKS clusters.

Which issue(s) this PR fixes:
Fixes #5516

Special notes for your reviewer:

  • The EKSAMILookupType has been extended to include AmazonLinux2023 and AmazonLinux2023GPU.
  • Updated the SSM parameter lookup logic to handle the new AMI types.

Checklist:

  • squashed commits
  • includes documentation
  • includes emoji in title ✨
  • adds unit tests
  • adds or updates e2e tests

Release note:

✨ Added support for Amazon Linux 2023 and Amazon Linux 2023 GPU AMI lookup in EKS optimized AMI workflow.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 3, 2025
Copy link

linux-foundation-easycla bot commented Jun 3, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

Welcome @matzegebbe!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 3, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @matzegebbe. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matzegebbe matzegebbe changed the title feat: add amazon-linux-2023 ami lookup parameters for ssm ✨ ✨ feat: add amazon-linux-2023 ami lookup parameters for ssm Jun 3, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 3, 2025
@afarbos
Copy link
Contributor

afarbos commented Jun 6, 2025

This is important to enable the use of K8S/EKS 1.33.

https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions-standard.html

AWS is not releasing an EKS-optimized Amazon Linux 2 AMI for Kubernetes 1.33.

https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions-standard.html#al2-ami-deprecation

For Kubernetes versions 1.33 and later, EKS will not provide pre-built optimized Amazon Linux 2 (AL2) Amazon Machine Images (AMIs).

@richardcase
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 8, 2025
@richardcase
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2025
@matzegebbe
Copy link
Contributor Author

I will fix asap

@matzegebbe
Copy link
Contributor Author

/retest

1 similar comment
@matzegebbe
Copy link
Contributor Author

/retest

@richardcase
Copy link
Member

/test pull-cluster-api-provider-aws-e2e-blocking

@dlipovetsky
Copy link
Contributor

Failure appears related to infrastructure, not the PR.

/retest

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 16, 2025
@dlipovetsky
Copy link
Contributor

The release note markdown block was missing the ending quotes. I added them.

@dlipovetsky
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 945a0f4d1080a99da479f2fb2941fb1bb8771877

@k8s-ci-robot k8s-ci-robot merged commit 6725536 into kubernetes-sigs:main Jun 16, 2025
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v2.8 milestone Jun 16, 2025
@dlipovetsky
Copy link
Contributor

/cherrypick release-2.8

@k8s-infra-cherrypick-robot

@dlipovetsky: new pull request created: #5555

In response to this:

/cherrypick release-2.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for AL2023 AMI support and public image publishing
6 participants