Skip to content

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #5517

/assign dlipovetsky

✨ Added support for Amazon Linux 2023 and Amazon Linux 2023 GPU AMI lookup in EKS optimized AMI workflow.

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 17, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 17, 2025
@k8s-ci-robot k8s-ci-robot requested review from AndiDog and faiq June 17, 2025 21:11
@k8s-ci-robot k8s-ci-robot added needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 17, 2025
@dlipovetsky
Copy link
Contributor

/approve

/test pull-cluster-api-provider-aws-e2e-blocking

@k8s-ci-robot
Copy link
Contributor

@dlipovetsky: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-aws-build
/test pull-cluster-api-provider-aws-build-docker

Use /test all to run all jobs.

In response to this:

/approve

/test pull-cluster-api-provider-aws-e2e-blocking

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlipovetsky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2025
@dlipovetsky
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9f374d58fb1a536c950161a5b4bc5a9a1de2b866

@k8s-ci-robot k8s-ci-robot merged commit 2d900a1 into kubernetes-sigs:release-2.8 Jun 18, 2025
12 checks passed
@matzegebbe
Copy link
Contributor

Hey! Sorry, I completely overlooked the PR #5553.

If I spin up nodes now with AmazonLinux2003 set, they are unable to join the cluster because /etc/eks/bootstrap.sh no longer works. We’ll need to wait for #5553.

spec:
  template:
    spec:
      iamInstanceProfile: nodes.cluster-api-provider-aws.sigs.k8s.io
      ami:
        eksLookupType: AmazonLinux2023
 ...

Apologies for not testing thoroughly before changing the AMI image - the machine itself does spin up, though.

SCR-20250825-pgqj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants