Skip to content

Conversation

chrischdi
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

In CAPI and CAPV we added the prowjob-gen tool (which lives in https://github.com/kubernetes-sigs/cluster-api/tree/main/hack/tools/prowjob-gen ) which allows generating prowjob configurations in test-infra via templates to ensure consistency and easier addition of jobs for new release branches.

In addition to

Example usage:

$ TEST_INFRA_DIR=../../k8s.io/test-infra make generate-test-infra-prowjobs
hack/tools/bin/prowjob-gen \
                -config "../../k8s.io/test-infra/config/jobs/kubernetes-sigs/cluster-api-provider-aws/cluster-api-provider-aws-prowjob-gen.yaml" \
                -templates-dir "../../k8s.io/test-infra/config/jobs/kubernetes-sigs/cluster-api-provider-aws/templates" \
                -output-dir "../../k8s.io/test-infra/config/jobs/kubernetes-sigs/cluster-api-provider-aws"
I0905 10:49:58.979161   48321 generator.go:127] Deleting file cluster-api-provider-aws-periodics-main.yaml
I0905 10:49:58.979581   48321 generator.go:127] Deleting file cluster-api-provider-aws-periodics-release-2.7.yaml
I0905 10:49:58.979987   48321 generator.go:127] Deleting file cluster-api-provider-aws-periodics-release-2.8.yaml
I0905 10:49:58.980216   48321 generator.go:127] Deleting file cluster-api-provider-aws-periodics-release-2.9.yaml
I0905 10:49:58.980655   48321 generator.go:127] Deleting file cluster-api-provider-aws-presubmits-main.yaml
I0905 10:49:58.981056   48321 generator.go:127] Deleting file cluster-api-provider-aws-presubmits-release-2.7.yaml
I0905 10:49:58.981386   48321 generator.go:127] Deleting file cluster-api-provider-aws-presubmits-release-2.8.yaml
I0905 10:49:58.981661   48321 generator.go:127] Deleting file cluster-api-provider-aws-presubmits-release-2.9.yaml
I0905 10:49:58.981717   48321 generator.go:84] Executing and writing template "cluster-api-provider-aws-periodics.yaml.tpl" for branch "main"
I0905 10:49:58.981898   48321 generator.go:84] Executing and writing template "cluster-api-provider-aws-periodics.yaml.tpl" for branch "release-2.7"
I0905 10:49:58.981981   48321 generator.go:84] Executing and writing template "cluster-api-provider-aws-periodics.yaml.tpl" for branch "release-2.8"
I0905 10:49:58.982069   48321 generator.go:84] Executing and writing template "cluster-api-provider-aws-periodics.yaml.tpl" for branch "release-2.9"
I0905 10:49:58.982148   48321 generator.go:84] Executing and writing template "cluster-api-provider-aws-presubmits.yaml.tpl" for branch "main"
I0905 10:49:58.982293   48321 generator.go:84] Executing and writing template "cluster-api-provider-aws-presubmits.yaml.tpl" for branch "release-2.7"
I0905 10:49:58.982427   48321 generator.go:84] Executing and writing template "cluster-api-provider-aws-presubmits.yaml.tpl" for branch "release-2.8"
I0905 10:49:58.982545   48321 generator.go:84] Executing and writing template "cluster-api-provider-aws-presubmits.yaml.tpl" for branch "release-2.9"

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emoji in title
  • adds unit tests
  • adds or updates e2e tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 5, 2025
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition! Thanks!

/lgtm

/assign @richardcase @nrb

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4fd4de23ee9df8beb0b772cb678161e9f2e8936e

@richardcase
Copy link
Member

This is great, thanks @chrischdi

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2025
@k8s-ci-robot k8s-ci-robot merged commit 4532d16 into kubernetes-sigs:main Sep 5, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants