Skip to content

Conversation

@chrischdi
Copy link
Member

@chrischdi chrischdi commented Sep 5, 2025

/assign @nrb @damdo

See kubernetes-sigs/cluster-api-provider-aws#5650 for more context.

Note: I splitted the commits on purpose to make it easier to review.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 5, 2025
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 5, 2025
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change! Thanks @chrischdi

One Q.

@chrischdi chrischdi force-pushed the pr-capa-add-prowjob-gen branch from 71fe904 to e904f6c Compare September 5, 2025 09:01
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

TY

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2025
@chrischdi chrischdi force-pushed the pr-capa-add-prowjob-gen branch from 1d0e584 to f87cf0c Compare September 5, 2025 09:15
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2025
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2025
@richardcase
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi, richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2025
@k8s-ci-robot k8s-ci-robot merged commit 08ce536 into kubernetes:master Sep 5, 2025
6 checks passed
@k8s-ci-robot
Copy link
Contributor

@chrischdi: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-provider-aws-periodics.yaml using file ``
  • key cluster-api-provider-aws-periodics-main.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-aws/cluster-api-provider-aws-periodics-main.yaml
  • key cluster-api-provider-aws-periodics-release-2.7.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-aws/cluster-api-provider-aws-periodics-release-2.7.yaml
  • key cluster-api-provider-aws-periodics-release-2.8.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-aws/cluster-api-provider-aws-periodics-release-2.8.yaml
  • key cluster-api-provider-aws-periodics-release-2.9.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-aws/cluster-api-provider-aws-periodics-release-2.9.yaml
  • key cluster-api-provider-aws-presubmits.yaml using file ``
  • key cluster-api-provider-aws-presubmits-main.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-aws/cluster-api-provider-aws-presubmits-main.yaml
  • key cluster-api-provider-aws-presubmits-release-2.7.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-aws/cluster-api-provider-aws-presubmits-release-2.7.yaml
  • key cluster-api-provider-aws-presubmits-release-2.8.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-aws/cluster-api-provider-aws-presubmits-release-2.8.yaml
  • key cluster-api-provider-aws-presubmits-release-2.9.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-aws/cluster-api-provider-aws-presubmits-release-2.9.yaml
  • key cluster-api-provider-aws-prowjob-gen.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-aws/cluster-api-provider-aws-prowjob-gen.yaml

In response to this:

/assign @nrb @damdo

See kubernetes-sigs/cluster-api-provider-aws#5650 for more context.

Note: I splitted the commits on purpose to make it easier to review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants