-
Notifications
You must be signed in to change notification settings - Fork 460
rev coredns and etcd version for upgrade test #4715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rev coredns and etcd version for upgrade test #4715
Conversation
|
/test pull-cluster-api-provider-azure-e2e-workload-upgrade |
| FLATCAR_VERSION: "${FLATCAR_VERSION:-latest}" | ||
| ETCD_VERSION_UPGRADE_TO: "3.5.4-0" | ||
| COREDNS_VERSION_UPGRADE_TO: "v1.9.3" | ||
| COREDNS_VERSION_UPGRADE_TO: "v1.11.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 matches CAPI on the release-1.6 branch: https://github.com/kubernetes-sigs/cluster-api/blob/90d78fa0c57abacb88a9d158c61a47fe24cda229/test/e2e/config/docker.yaml#L322
Should we maybe bump etcd to 3.5.10-0 too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea.
Ace detective work @nojnhuh!
Signed-off-by: Jack Francis <[email protected]>
6740a31 to
336817f
Compare
nojnhuh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold to let the optional upgrade test finish.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nojnhuh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: eab38832cda9d9dfaf393ae46e544a94af3ecd4f
|
|
/test pull-cluster-api-provider-azure-e2e-workload-upgrade |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4715 +/- ##
=======================================
Coverage 62.73% 62.73%
=======================================
Files 192 192
Lines 15641 15641
=======================================
Hits 9812 9812
Misses 5146 5146
Partials 683 683 ☔ View full report in Codecov by Sentry. |
|
upgrade job passed! /hold cancel |
|
/cherry-pick release-1.14 I think this is holding up #4856. |
|
@nojnhuh: new pull request created: #4857 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
This PR updates the version of coredns used during the CAPI workload cluster upgrade test to match the current version in CAPI main branch.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: