Define NoSchedule tolerations for tigera-operator #5704
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XL
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5704 +/- ##
=======================================
Coverage 52.83% 52.83%
=======================================
Files 278 278
Lines 29610 29610
=======================================
Hits 15645 15645
Misses 13148 13148
Partials 817 817 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I just pushed a hack to run more tests at once here. /retitle [WIP] Define NoSchedule tolerations for tigera-operator |
k8s-ci-robot
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
/test pull-cluster-api-provider-azure-e2e-workload-upgrade |
nojnhuh
force-pushed
the
tigera-tolerations
branch
from
39b34f2 to
6fff937
Compare
With 2x3 runs of each test all getting past the flake this is targeting, that gives me hope. Hack is removed and this is ready for review. /retitle Define NoSchedule tolerations for tigera-operator |
nojnhuh
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
| releaseName: projectcalico | ||
| repoURL: https://docs.tigera.io/calico/charts | ||
| valuesTemplate: |- | ||
| valuesTemplate: | |
There was a problem hiding this comment.
| keeps the trailing new line while |- removes the final trailing new line
So in practice if we know the section is going to end the yaml we want it to have | ?
There was a problem hiding this comment.
The newline that gets stripped is only the newline at the end of this string value for the key valuesTemplate, not the whole file. Some of the files I changed here didn't happen to have a newline at the end of the file whereas the new section that got tacked on by this PR does, which is why I think this changed. In general though, I don't think whether there's a newline or not at the end of a valuesTemplate matters.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 522967d7ff6c0e8edda3d12d0cf5bb46404a7f3d
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: willie-yao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest-required |
1 similar comment
|
/retest-required |
|
/retest |
|
@nojnhuh: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest |
|
/cherry-pick release-1.20 #5889 is failing and this should fix it. |
|
@nojnhuh: #5704 failed to apply on top of branch "release-1.20": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5 participants
What type of PR is this?
/kind flake
What this PR does / why we need it:
This PR changes the tigera-operator Pod to tolerate only the NoSchedule tolerations that are set when a Node is being bootstrapped instead of all of them (which includes the
node.kubernetes.io/unschedulabletaint set when a Node is cordoned and drained).Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #5703
Special notes for your reviewer:
TODOs:
Release note: