Skip to content

[release-1.20] update azidentity to v1.12.0 #5889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2025
Merged

[release-1.20] update azidentity to v1.12.0 #5889

merged 1 commit into from
Oct 2, 2025

Conversation

@jackfrancis
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Update azidentity to v1.12.0 w/ beneficial side-effects.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #5785

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

update azidentity to v1.12.0

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 30, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 30, 2025
nojnhuh
nojnhuh approved these changes Sep 30, 2025
View reviewed changes
Copy link
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8f645460b69e259aa7eba26fd4fcc4f05f2257a7

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2025
@codecov
Copy link

codecov bot commented Sep 30, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.81%. Comparing base (58587ac) to head (be37408).
⚠️ Report is 5 commits behind head on release-1.20.

Additional details and impacted files 
@@              Coverage Diff              @@
##           release-1.20    #5889   +/-   ##
=============================================
  Coverage         52.81%   52.81%           
=============================================
  Files               279      279           
  Lines             29602    29602           
=============================================
  Hits              15634    15634           
  Misses            13154    13154           
  Partials            814      814

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jackfrancis jackfrancis mentioned this pull request Sep 30, 2025
Open
@nojnhuh
Copy link
Contributor

nojnhuh commented Oct 1, 2025

/retest

1 similar comment
@nojnhuh
Copy link
Contributor

nojnhuh commented Oct 1, 2025

/retest

@nojnhuh nojnhuh mentioned this pull request Oct 1, 2025
Merged
4 tasks
@nojnhuh
Copy link
Contributor

nojnhuh commented Oct 1, 2025

The release-1.20 branch needs #5704 cherry picked. I'll try the roulette wheel one more time.

/retest

@nojnhuh
Copy link
Contributor

nojnhuh commented Oct 1, 2025

The release-1.20 branch needs #5704 cherry picked.

#5890

@nojnhuh
Copy link
Contributor

nojnhuh commented Oct 1, 2025

#5890 merged, this test should pass now.

/retest

@nojnhuh
Copy link
Contributor

nojnhuh commented Oct 1, 2025

/retest

@k8s-ci-robot k8s-ci-robot merged commit fe77e18 into kubernetes-sigs:release-1.20 Oct 2, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nojnhuh nojnhuh nojnhuh approved these changes

@Jont828 Jont828 Awaiting requested review from Jont828

@mboersma mboersma Awaiting requested review from mboersma

Assignees

@nojnhuh nojnhuh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

CAPZ Planning
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jackfrancis @k8s-ci-robot @nojnhuh