Skip to content

chore: don't use Requeue in controller-runtime #1516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2025
Merged

chore: don't use Requeue in controller-runtime #1516

merged 1 commit into from
Aug 31, 2025
+3 −21

Conversation

@justinsb
Copy link
Contributor

@justinsb justinsb commented Aug 29, 2025 •
edited
Loading

It is deprecated in newer versions of controller-runtime,
because it should not be used.


NONE

@justinsb
chore: don't use Requeue in controller-runtime
2dcd7ab 
It is deprecated in newer versions of controller-runtime,
because it should not be used.
@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Aug 29, 2025
@netlify
Copy link

netlify bot commented Aug 29, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name Link
🔨 Latest commit 2dcd7ab
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-gcp/deploys/68b1761d3c67530009b766e5
😎 Deploy Preview https://deploy-preview-1516--kubernetes-sigs-cluster-api-gcp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 29, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from cpanato and damdo August 29, 2025 09:42
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 29, 2025
@justinsb
Copy link
Contributor Author

We're going to need this to bump controller-runtime, but we might want to cherry-pick to 1.10 (and it makes #1509 smaller)

@justinsb justinsb mentioned this pull request Aug 29, 2025
Merged
@salasberryfin
Copy link
Contributor

Thanks @justinsb

/lgtm

/cherrypick release-1.10

@k8s-infra-cherrypick-robot
Copy link

@salasberryfin: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you.

In response to this:

Thanks @justinsb

/lgtm

/cherrypick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2025
@k8s-ci-robot k8s-ci-robot merged commit a271350 into kubernetes-sigs:main Aug 31, 2025
21 checks passed
@k8s-infra-cherrypick-robot
Copy link

@salasberryfin: new pull request created: #1520

In response to this:

Thanks @justinsb

/lgtm

/cherrypick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Aug 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpanato cpanato Awaiting requested review from cpanato

@damdo damdo Awaiting requested review from damdo

Assignees

@salasberryfin salasberryfin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@justinsb @k8s-ci-robot @salasberryfin @k8s-infra-cherrypick-robot