Adopt v1beta2 conditions for IBM VPC Machine #2447
Open
+559
−142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
area/provider/ibmcloud
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Amulyam24 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
size/XL
Amulyam24
force-pushed
the
vpc-machine-v1beta2
branch
from
02c00f7 to
babe366
Compare
|
Karthik-K-N
reviewed
Jul 30, 2025
| // Before computing ready condition, make sure that InstanceReady is always set. | ||
| // NOTE: This is required because v1beta2 conditions comply to guideline requiring conditions to be set at the | ||
| // first reconcile. | ||
| if c := v1beta2conditions.Get(ibmVPCMachine, infrav1.IBMVPCMachineInstanceReadyV1Beta2Condition); c == nil { |
There was a problem hiding this comment.
Is it possible to add a test case , where we can make sure that the IBMVPCMachineInstanceReadyV1Beta2Condition is set on the first reconcilation?
Just call a Reconcile and see whether the condition is set or not?
There was a problem hiding this comment.
Sure, will check if this can be done and add the test case.
There was a problem hiding this comment.
@Karthik-K-N, adding this seems more like a functional test case rather than UT. IMO, we can take it up as a follow up task in favour of merging this PR - wdyt?
There was a problem hiding this comment.
Sure, That should be ok, Unless we dont forget this, @arshadd-b is also adding similar test to IBMPowerVSImage, Please check if the similar approach can be followed,
There was a problem hiding this comment.
Added the test case and also tested cluster creation after final changes, PTAL!
Amulyam24
force-pushed
the
vpc-machine-v1beta2
branch
6 times, most recently
from
3fd5daf to
c38a9e2
Compare
Amulyam24
force-pushed
the
vpc-machine-v1beta2
branch
from
c38a9e2 to
5f1ec6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR includes changes for
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes part of #2389
Special notes for your reviewer:
/area provider/ibmcloud
Release note: