Update tags proposal by arshadd-b · Pull Request #2609 · kubernetes-sigs/cluster-api-provider-ibmcloud

arshadd-b · 2026-01-27T13:46:59Z

What this PR does / why we need it:
Improves tags proposal
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/area provider/ibmcloud

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Update tags proposal

netlify · 2026-01-27T13:47:07Z

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name	Link
🔨 Latest commit	`a20e0b8`
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-sigs-cluster-api-ibmcloud/deploys/69a6d4075e38ce0008821690
😎 Deploy Preview	https://deploy-preview-2609.cluster-api-ibmcloud.sigs.k8s.io
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

k8s-ci-robot · 2026-01-27T13:47:08Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arshadd-b
Once this PR has been reviewed and has the lgtm label, please assign prajyot-parab for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

arshadd-b · 2026-01-28T05:04:00Z

Hi @Amulyam24
Actually while we are implementing this tags feature , have encountered one scenario when we are creating cluster infra
what if resource is created and attaching tag fails . In some resources we are making different call for resource creation and attach tag like LB, VPC. In this case we are thinking if attach tag fails then we will also delete the resource before we return error.
Could you please let me know your thoughts. Thanks
cc: @Karthik-K-N

Karthik-K-N · 2026-01-29T04:10:41Z

docs/proposal/controller-and-user-tags.md

 Below are the cluster creation scenarios.
 #### Creating a new cluster 
- - When resources will be created for new cluster in the cloud the tag will be attached. During deletion flow, will check for tag `powervs.cluster.x-k8s.io/cluster-uuid: UUID` and delete the resources.
+ - When resources will be created for new cluster in the cloud the tag will be attached. During deletion flow, will check for tag `powervs.cluster.x-k8s.io/cluster-uuid: UUID` and delete the resources. During creation if resource is created successfully but failed to attach the tag, will clean up the created resource as well before returning error.


I am not sure what else we can do, If we relax resource creation then deletion will be an issue.

I think we need to set some condition or event or something to let the user explicitly know that tag is failing so not able to proceed in creating the resource?

/cc @dharaneeshvrd

But the thing is we have different calls for creation and attach . So the resource is created but attached failed we will error out to user and set condition but what about that created resource ?

What if we retry the attach tag alone for a few times and if it doesn't succeed, then proceed with deletion, notifying the user to try a different region? Not sure if tagging is affected across regions

yeah makes sense to me , we can have retry on attach tag itself and after that as well if it is failing, we will delete the resource and ask the user to try in different region

Say the tag fails for multiple retries and you want to delete all the resources created by the controller then in the next reconcile the the controller will again creates the resources. Isn't it?

yeah actually what I am thinking if attach tag is failing , we will retry there itself instead of reconcile. If after retries still it fails we will delete resource and error to user to try in different region. If again user trigger cluster creation in the same region then yes again reconcile will happen and same process will be repeated . But not sure what else we can do here .

If after retries still it fails we will delete resource and error to user trying in different region.

How do you do this in controller?

If after retries still it fails we will delete resource and error to user trying in different region.

How do you do this in controller?

I think we will just error out to user, User has to provide different region

Had a discussion in CAPIBM meeting and also with Arshad and here are the points we can do

Lets create a condition type something like AttachTag and set it on the IBMPowerVSCluster whenever a tag creation fails

The condition message should be descriptive, Should be like "Failed to attach tag to newly created Workspace "workspace-name", either manually attach tag or delete the cluster and retry it in different region.

Thanks @Karthik-K-N I will update the proposal as well with these details

Karthik-K-N · 2026-02-23T15:36:19Z

docs/proposal/controller-and-user-tags.md

 Below are the cluster creation scenarios.
 #### Creating a new cluster 
- - When resources will be created for new cluster in the cloud the tag will be attached. During deletion flow, will check for tag `powervs.cluster.x-k8s.io/cluster-uuid: UUID` and delete the resources.
+ - When resources will be created for new cluster in the cloud the tag will be attached. During deletion flow, will check for tag `powervs.cluster.x-k8s.io/cluster-uuid: UUID` and delete the resources. During creation if resource is created successfully but failed to attach the tag, will retry for some time and if it still fails, we will set condition with descriptive message `Failed to attach tag to newly created Workspace workspace-name, either manually attach tag or delete the cluster and retry it in different region.`


This approach LGTM but I think it should be documented in generic format, . @Amulyam24 Please suggest

I think it will be good to list down failure and success scenarios separately for readability.

You might want to add details about the new condition as well with an example?

Hi @Amulyam24 I am done with suggested changes
Thanks

Amulyam24

Overall LGTM, have added minor comments.

Amulyam24 · 2026-03-11T07:12:06Z

docs/proposal/controller-and-user-tags.md

+    When the user triggers deletion of a cluster where tag attachment previously failed, the controller will check the condition status. Based on this condition, the controller will determine whether to proceed with resource deletion.
+


This point seems vague, you might have to add specific details on the action being taken by the controller.

Amulyam24 · 2026-03-11T07:13:01Z

docs/proposal/controller-and-user-tags.md

 Below are the cluster creation scenarios.
 #### Creating a new cluster 
 - When resources will be created for new cluster in the cloud the tag will be attached. During deletion flow, will check for tag `powervs.cluster.x-k8s.io/cluster-uuid: UUID` and delete the resources.
+ ##### Tag Attachment Scenarios


Can you PTAL at the format of this section?

Amulyam24 · 2026-03-11T07:13:57Z

docs/proposal/controller-and-user-tags.md

+   	1. Retry Attempts: The controller retries attaching the tag multiple times over a configured period.
+	2. After Retries Fail: If all retries fail, the controller:
+		- Sets a warning condition on the cluster
+   		- Adds an error message like: "Failed to attach tag to newly created Workspace <workspace-name>. Please manually attach the tag or delete the cluster and recreate it."


nit: an example of the condition in the status field would be helpful

Amulyam24 · 2026-03-11T07:16:10Z

docs/proposal/controller-and-user-tags.md

+   	1. Retry Attempts: The controller retries attaching the tag multiple times over a configured period.
+	2. After Retries Fail: If all retries fail, the controller:
+		- Sets a warning condition on the cluster
+   		- Adds an error message like: "Failed to attach tag to newly created Workspace <workspace-name>. Please manually attach the tag or delete the cluster and recreate it."


Please manually attach the tag or delete the cluster and recreate it."

@arshadd-b @Karthik-K-N, for my understanding, what would be the purpose of user manually attaching the tag if the tag creation fails when we would proceed with deletion based on the condition being set and it is being handled for success and failure case?

k8s-ci-robot added the area/provider/ibmcloud Issues or PRs related to ibmcloud provider label Jan 27, 2026

k8s-ci-robot requested review from Amulyam24 and mkumatag January 27, 2026 13:47

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 27, 2026

Karthik-K-N reviewed Jan 29, 2026

View reviewed changes

k8s-ci-robot requested a review from dharaneeshvrd January 29, 2026 04:10

arshadd-b force-pushed the update-tag-proposal branch from 105b534 to f8fe67d Compare February 19, 2026 08:40

update tags proposal

2ed7377

arshadd-b force-pushed the update-tag-proposal branch from f8fe67d to 2ed7377 Compare February 19, 2026 08:42

arshadd-b requested a review from Karthik-K-N February 19, 2026 08:42

Karthik-K-N reviewed Feb 23, 2026

View reviewed changes

address review comment

871e71b

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 3, 2026

arshadd-b requested a review from Karthik-K-N March 3, 2026 12:19

arshadd-b force-pushed the update-tag-proposal branch from b4b218a to fb3be78 Compare March 3, 2026 12:26

address review comments

a20e0b8

arshadd-b force-pushed the update-tag-proposal branch from fb3be78 to a20e0b8 Compare March 3, 2026 12:28

Amulyam24 reviewed Mar 11, 2026

View reviewed changes

		When the user triggers deletion of a cluster where tag attachment previously failed, the controller will check the condition status. Based on this condition, the controller will determine whether to proceed with resource deletion.

Conversation

arshadd-b commented Jan 27, 2026 • edited by Prajyot-Parab Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Uh oh!

k8s-ci-robot commented Jan 27, 2026

Uh oh!

arshadd-b commented Jan 28, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arshadd-b Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arshadd-b Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Karthik-K-N Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Amulyam24 Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Amulyam24 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

arshadd-b commented Jan 27, 2026 •

edited by Prajyot-Parab

Loading

netlify bot commented Jan 27, 2026 •

edited

Loading

arshadd-b Feb 2, 2026 •

edited

Loading

arshadd-b Feb 11, 2026 •

edited

Loading

Karthik-K-N Feb 11, 2026 •

edited

Loading

Amulyam24 Feb 24, 2026 •

edited

Loading