Skip to content

Update tags proposal #2609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arshadd-b wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update tags proposal #2609

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ed7377
update tags proposal
arshadd-b Jan 27, 2026
871e71b
address review comment
arshadd-b Feb 25, 2026
a20e0b8
address review comments
arshadd-b Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/proposal/controller-and-user-tags.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ This proposal presents adding two kinds of tags to the resources created by cont

Below are the cluster creation scenarios.
#### Creating a new cluster
- When resources will be created for new cluster in the cloud the tag will be attached. During deletion flow, will check for tag `powervs.cluster.x-k8s.io/cluster-uuid: UUID` and delete the resources.
- When resources will be created for new cluster in the cloud the tag will be attached. During deletion flow, will check for tag `powervs.cluster.x-k8s.io/cluster-uuid: UUID` and delete the resources. During creation if resource is created successfully but failed to attach the tag, will retry for some time and if it still fails, we will set condition with descriptive message `Failed to attach tag to newly created Workspace workspace-name, either manually attach tag or delete the cluster and retry it in different region.`
Copy link
Contributor

@Karthik-K-N Karthik-K-N Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach LGTM but I think it should be documented in generic format, . @Amulyam24 Please suggest

Copy link
Contributor

@Amulyam24 Amulyam24 Feb 24, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will be good to list down failure and success scenarios separately for readability.

You might want to add details about the new condition as well with an example?

Copy link
Contributor Author

@arshadd-b arshadd-b Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Amulyam24 I am done with suggested changes
Thanks

#### Creating a new cluster with reusing pre-created resources
- When cluster is created using existing resources, no tag will be attached. We won't delete these resources, as these were not created by controller.
#### Creating a new cluster with reusing pre-created resources from old cluster.
Expand All @@ -50,7 +50,7 @@ This proposal presents adding two kinds of tags to the resources created by cont
8. [COS Instance](https://www.ibm.com/products/cloud-object-storage)

#### Note
- When TransitGateway is tagged we can delete connections. But there is case when TransitGateway is not newly created but connections are newly created. But we cannot delete connections since it doesn't support tagging. So to delete TransitGateway connections have to add tag `powervs.cluster.x-k8s.io/owner/<cluster-name>/TG: vpcconnection, powervsconnection` to TransitGateway. So will check if this tag is added to TransitGateway, will move with the deletion of connections.
- When TransitGateway is tagged we can delete connections. But there is case when TransitGateway is not newly created but connections are newly created. But we cannot delete connections since it doesn't support tagging. So to delete TransitGateway connections have to add tag `powervs.cluster.x-k8s.io/owner/<cluster-name>/TG: vpcconnectionID, powervsconnectionID` to TransitGateway. So will check if this tag is added to TransitGateway, will move with the deletion of connections.

- To handle deletion DHCP server, have to tag DHCP Network. DHCP server doesn't support tagging.

Expand Down