📖 Update release role docs to be more clear about checking security and ci test results #12163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/documentation
k8s-ci-robot
added
the
size/S
Signed-off-by: cprivitere <[email protected]>
mboersma
approved these changes
May 7, 2025
There was a problem hiding this comment.
/lgtm
Indeed, I must have missed this task in the v1.10 cycle. 🫤 Thanks for making it clear @cprivitere!
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: d4d6b93f0ceb80d217faab5af2e010220e0cae2c
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Thank you! /lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We were having failed results in our Weekly scans for weeks because both the Release Lead and CI Manager (aka me) didn't realize there was a security scan github action they were supposed to be checking.
This PR updates the role documentation to explicitly callout and link to this scan as well as the other results that they should be checking regularly.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #12162
/area documentation
/area release