-
Notifications
You must be signed in to change notification settings - Fork 447
🌱Bump to k8s.io/* v0.34.0-alpha.1 #1214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @dongjiang1989. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test @dongjiang1989 Thx for the PR, if there is no need to bump to alpha.1 at this time. I would probably defer merging this until later until we have a beta. As soon as we merge this we would have to branch away to create v0.18.x patch release. I would like to avoid this if there is no need to pick up the alpha of v0.34 already. In any case it's good to see if CI is still green and we can continue to bump k8s.io on this PR to run tests |
Signed-off-by: dongjiang <[email protected]>
06089e0
to
0f84126
Compare
Thanks @sbueringer |
cc @alvaroaleman (in case you want to bump to alpha.1 now somehow in the context of the ongoing SSA work) |
No, the changes I would need aren't in alpha.1, but probably good to use the latest version regardless |
I'm also fine with bumping. Just have to keep in mind that we should create a release branch based on a commit before this PR + start cherry-picking if we want to do patch releases of v0.18.0 (just mentioning it because in CT we often released patches from main, but not a big deal) |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dongjiang1989 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: dongjiang <[email protected]>
@dongjiang1989 Please rebase onto main & squash (to remove the merge commit) |
@dongjiang1989: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
+ let's bump to alpha 2 directly |
Thanks @sbueringer add PR #1225 I'll close this PR |
Bump the k8s.io/* deps to the latest tag