Skip to content

🌱Bump to k8s.io/* v0.34.0-alpha.2 #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2025
Merged

🌱Bump to k8s.io/* v0.34.0-alpha.2 #1225

merged 1 commit into from
Jun 27, 2025
+152 −118

Conversation

dongjiang1989
Copy link
Contributor

Bump to k8s.io/* v0.34.0-alpha.2

#1214 (comment)

cc @sbueringer

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 27, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 27, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @dongjiang1989. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 27, 2025
@dongjiang1989 dongjiang1989 mentioned this pull request Jun 27, 2025
Closed
@dongjiang1989 dongjiang1989 force-pushed the update-v0.34.0-alpha.2 branch from 8f67d76 to 4e9b88e Compare June 27, 2025 06:03
@sbueringer
Copy link
Member

Thx!

/ok-to-test

/lgtm

/cc @alvaroaleman

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 27, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c96dcffa458a6a9fefd16c98b352952db4a36fb9

sbueringer
sbueringer reviewed Jun 27, 2025
View reviewed changes
pkg/applyconfiguration/testdata/cronjob/api/v1/applyconfiguration/utils.go
@@ -53,6 +53,6 @@ func ForKind(kind schema.GroupVersionKind) interface{} {
return nil
}

func NewTypeConverter(scheme *runtime.Scheme) *testing.TypeConverter {
return &testing.TypeConverter{Scheme: scheme, TypeResolver: internal.Parser()}
func NewTypeConverter(scheme *runtime.Scheme) managedfields.TypeConverter {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I see correctly with this change this now matches up exactly with CR: kubernetes-sigs/controller-runtime#2981

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it
This change by controller-gen applyconfiguration paths=./api/...

@sbueringer
Copy link
Member

Needs some more test fixes

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2025
@k8s-ci-robot k8s-ci-robot requested a review from sbueringer June 27, 2025 10:21
@dongjiang1989
update to v0.34.0-alpha.2
b632fde 
Signed-off-by: dongjiang <[email protected]>

fix unittest case

Signed-off-by: dongjiang <[email protected]>
@dongjiang1989 dongjiang1989 force-pushed the update-v0.34.0-alpha.2 branch from ed139df to b632fde Compare June 27, 2025 10:21
@dongjiang1989
Copy link
Contributor Author

dongjiang1989 commented Jun 27, 2025 •
edited
Loading

Needs some more test fixes

Thanks @sbueringer
Unittest case fixed

Please re-check this PR

alvaroaleman
alvaroaleman reviewed Jun 27, 2025
View reviewed changes
pkg/applyconfiguration/testdata/cronjob/api/v1/applyconfiguration/api/v1/cronjobspec.go
@@ -101,6 +101,7 @@ type CronJobSpecApplyConfiguration struct {
func CronJobSpec() *CronJobSpecApplyConfiguration {
return &CronJobSpecApplyConfiguration{}
}
func (b CronJobSpecApplyConfiguration) IsApplyConfiguration() {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Urgh, this is wrong, opened kubernetes/kubernetes#132584 for the fix

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Nothing to do with your change, just made me aware)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4145c33f4ac67172bfdaf34912f35bd57f2082da

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, dongjiang1989

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2025
@k8s-ci-robot k8s-ci-robot merged commit 8c6352e into kubernetes-sigs:main Jun 27, 2025
8 checks passed
@dongjiang1989 dongjiang1989 deleted the update-v0.34.0-alpha.2 branch June 28, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaroaleman alvaroaleman alvaroaleman approved these changes

@joelanford joelanford Awaiting requested review from joelanford

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@sbueringer sbueringer

@alvaroaleman alvaroaleman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dongjiang1989 @k8s-ci-robot @sbueringer @alvaroaleman