-
Notifications
You must be signed in to change notification settings - Fork 112
examples: fix staticcheck issues (SA4022, SA1029) in kind_with_config #528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
examples: fix staticcheck issues (SA4022, SA1029) in kind_with_config #528
Conversation
Fix two staticcheck issues found in examples/kind/kind_with_config:
- Avoid comparing address of variable to nil (SA4022)
- Use dedicated key type instead of string for context.WithValue (SA1029)
Although examples are excluded from linter checks, they are widely copied by users.
Fixing these issues prevents spreading bad patterns and keeps the examples correct.
Verified with:
staticcheck ./examples/kind/kind_with_config/...
go test ./examples/kind/kind_with_config/...
Signed-off-by: Andrey Petrov <[email protected]>
|
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: av-petrov The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @av-petrov! |
|
Hi @av-petrov. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
I signed it |
1 similar comment
|
I signed it |
|
/test all |
|
/ok-to-test |
Fix two staticcheck issues found in examples/kind/kind_with_config:
Although examples are excluded from linter checks, they are widely copied by users.
Fixing these issues prevents spreading bad patterns and keeps the examples correct.
Verified with:
staticcheck ./examples/kind/kind_with_config/...
go test ./examples/kind/kind_with_config/...
Signed-off-by: Andrey Petrov [email protected]