Skip to content

examples: fix staticcheck issues (SA4022, SA1029) in kind_with_config #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
av-petrov wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −5
Open

examples: fix staticcheck issues (SA4022, SA1029) in kind_with_config #528

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions examples/kind/kind_with_config/kind_with_config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@ import (
"sigs.k8s.io/e2e-framework/pkg/features"
)

// unexported key type to avoid collisions in context (SA1029)
type depKeyType struct{}

var depKey depKeyType

func TestKindCluster(t *testing.T) {
deploymentFeature := features.New("appsv1/deployment").
Setup(func(ctx context.Context, t *testing.T, cfg *envconf.Config) context.Context {
Expand All @@ -44,13 +49,11 @@ func TestKindCluster(t *testing.T) {
if err := cfg.Client().Resources().Get(ctx, "test-deployment", cfg.Namespace(), &dep); err != nil {
t.Fatal(err)
}
if &dep != nil {
t.Logf("deployment found: %s", dep.Name)
}
return context.WithValue(ctx, "test-deployment", &dep)
t.Logf("deployment found: %s", dep.Name)
return context.WithValue(ctx, depKey, &dep)
}).
Teardown(func(ctx context.Context, t *testing.T, cfg *envconf.Config) context.Context {
dep := ctx.Value("test-deployment").(*appsv1.Deployment)
dep := ctx.Value(depKey).(*appsv1.Deployment)
if err := cfg.Client().Resources().Delete(ctx, dep); err != nil {
t.Fatal(err)
}
Expand Down