Skip to content

Add support for multi platform image #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 30, 2025
Merged

Add support for multi platform image #1010

Changes from 11 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
64e6f80
Add support for multi platform image
adarshagrawal38 Jun 19, 2025
ebf4e4f
Reseting GOOS and GOARCH
adarshagrawal38 Jun 19, 2025
b5054f4
Adding dependency to enable multi platform support
adarshagrawal38 Jun 25, 2025
3daad4f
Adding builder to support multi platform
adarshagrawal38 Jun 25, 2025
a1b420e
Removing load flag
adarshagrawal38 Jun 25, 2025
fde82a0
Updates
adarshagrawal38 Jun 25, 2025
1beab21
updates
adarshagrawal38 Jun 25, 2025
d4836db
Fix
adarshagrawal38 Jun 25, 2025
8dbf9f4
Fix issues
adarshagrawal38 Jun 25, 2025
2da52d0
Update
adarshagrawal38 Jun 25, 2025
358b8f9
Clean up
adarshagrawal38 Jun 25, 2025
108a827
Update command
adarshagrawal38 Jun 30, 2025
7f12696
Removing unsed cmd
adarshagrawal38 Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,9 +191,16 @@ image-build: ## Build the EPP image using Docker Buildx.
$(LOAD) \
$(IMAGE_BUILD_EXTRA_OPTS) ./

.PHONY: multi-platform-init
multi-platform-init: ## Set up Docker Buildx for multi-platform builds.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kfswain @ahg-g where is the job that build the epp:main image?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is here:
https://github.com/kubernetes-sigs/gateway-api-inference-extension/blob/main/cloudbuild.yaml

@docker buildx inspect multiplatform >/dev/null 2>&1 || docker buildx create --name multiplatform --use
@docker run --privileged --rm tonistiigi/binfmt --install all
@docker buildx inspect --bootstrap

.PHONY: image-push
image-push: PUSH=--push ## Build the EPP image and push it to $IMAGE_REPO.
image-push: image-build
image-push: PLATFORMS=linux/amd64,linux/arm64
image-push: multi-platform-init image-build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to support both dev (single-arch) and release (multi-arch) workflows. Here is an untested example of what I was thinking to support multi-arch and support the different dev/release flows. @kfswain @ahg-g this does require updating the CI job, e.g. MULTI=true, to build multi-arch images.


.PHONY: image-load
image-load: LOAD=--load ## Build the EPP image and load it in the local Docker registry.
Expand Down